-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip(sidecar): low-level SidecarDriver
#133
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
f271bef
to
f9d4a92
Compare
8940909
to
0d1ce4a
Compare
c385ec3
to
4ff1219
Compare
closed in favor of #181 |
This PR introduces a driver task for the main loop to replace the
tokio::select!
usage in our main binary.This is an experiment and probably not worth to merge until we have a more stable release of the sidecar.
To make the remaining handlers sync, we essentially need to process these 3 events synchronously:
The best way to do this is by turning execution and consensus state containers into actors and control them from the driver by their handles.