Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: symbiotic network opt-in #304

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

merklefruit
Copy link
Collaborator

Added a check to make the operator opt in to the network before registering in the middleware.
This will be skipped if it's already done by the operator beforehand.

@@ -19,7 +19,7 @@
"avsDirectory": "0x055733000064333CaDDbC92763c58BF0192fFeBf",
"delegationManager": "0xA44151489861Fe9e3055d95adC98FbD462B948e7",
"strategyManager": "0xdfB5f6CE42aAA7830E94ECFCcAd411beF4d4D5b6",
"middleware": "",
"middleware": "0x279F5be63FD1D0A32d77258028933a7e3E75fF08",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this out of the config so we don't accidentally set incorrect addresses

Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - not going to do the same for EigenLayer since it requires more information like operator metadata etc.

@merklefruit merklefruit merged commit 10adbfb into nico/feat/commitment-registry Oct 21, 2024
5 checks passed
@merklefruit merklefruit deleted the nico/chore/net-optin branch October 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants