chore(sidecar): cleanup + remove TODOs (continue) #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
force-pushed
the
nico/chore/sidecar-cleanup
branch
from
33dda28
to
22e9eb2
Compare
thedevbirb
approved these changes
Nov 11, 2024
| @@ -18,37 +18,22 @@ const BOLT: &str = r#" | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() -> eyre::Result<()> { | |||
| println!("{}", BOLT); | |||
There was a problem hiding this comment.
Curious -- do you prefer displaying the logo as the first thing or after all startup checks passed successfully?
I like the idea of seeing the logo knowing I've done everything well :D but maybe that's just me
There was a problem hiding this comment.
I get that, but I didn't like having other logs before the logo, such as:
[info] telemetry initialized!
LOGO
[...] other logs
instead it should be:
LOGO
[...] all logs
Not a blocker ofc, let's just pick one :)
There was a problem hiding this comment.
nvm, let's merge this! We can modify it at a later time if we wish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some small TODOs and cleans up the logic in the bolt manager pubkey verification.