-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fast multi-platform build #389
Open
merklefruit
wants to merge
13
commits into
unstable
Choose a base branch
from
nico/cross-builds
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, super happy we got it working with the binary-based approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several failed attempts (cross, xx-cargo, etc) we can finally build our rust binaries for both x86 and arm targets!
We now use
cargo-zigbuild
which swaps out the linker used by Cargo with Zig.Benefits:
release
binary of the bolt-sidecar! 🏎️zig
has solved some of the nasty linker errors we were getting with other approachesDownsides:
aarch64-unknown-linux-gnu
are failing on my Macbook with M2 chip. When building on an x86-based server everything runs smooth for all our targets though. The most likely cause is that macOS uses a different ABI (Mach-O) and libc (libSystem), which doesn’t satisfy what the GNU environment for aarch64 requires. Zig isn’t fully substituting for these missing components, which causes the error.Usage
Available packages that can be built from this repo (so far):
bolt-sidecar
,bolt-boost
.Example to produce a cross-platform docker image with tag
unstable
:Example to produce cross-platform docker images for all available packages mentioned above with tag
unstable
:Requisites to build images
cargo
zig
cargo-zigbuild
docker buildx