Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(releases): more reliable releases #1653

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

luhring
Copy link
Member

@luhring luhring commented Nov 15, 2024

  • Consolidate release workflows into one
  • Continue to use a scheduled check for new changes
  • Also allow manual triggering of release creation

@luhring luhring force-pushed the unfck-releases branch 2 times, most recently from 263dc57 to 66c35c5 Compare November 15, 2024 18:47
- Consolidate release workflows into one
- Continue to use a scheduled check for new changes
- Also allow manual triggering of release creation

Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
@k4leung4
Copy link
Contributor

do we really need daily releases?
the reason i ask is that this repo is also consumed as a go dep
daily releases mean frequent dependabot PRs

what changes are we needing to release daily and would it make sense to refactor the repo into a library and cli such that downstream can depend on something a bit more stable?

@luhring
Copy link
Member Author

luhring commented Nov 15, 2024

do we really need daily releases? the reason i ask is that this repo is also consumed as a go dep daily releases mean frequent dependabot PRs

what changes are we needing to release daily and would it make sense to refactor the repo into a library and cli such that downstream can depend on something a bit more stable?

The short answer is that we do tend to make updates to melange fairly often (daily is not unusual) that we want to bring into other tools and services.

I'm not married to daily — but note that this isn't new as of this PR, this PR is just trying to get releases working like we meant for them to before.

@luhring luhring marked this pull request as ready for review November 15, 2024 21:12
@k4leung4
Copy link
Contributor

do we really need daily releases? the reason i ask is that this repo is also consumed as a go dep daily releases mean frequent dependabot PRs
what changes are we needing to release daily and would it make sense to refactor the repo into a library and cli such that downstream can depend on something a bit more stable?

The short answer is that we do tend to make updates to melange fairly often (daily is not unusual) that we want to bring into other tools and services.

I'm not married to daily — but note that this isn't new as of this PR, this PR is just trying to get releases working like we meant for them to before.

agree this isnt new, but its a pain in mono trying to stay up to date with this dep, especially when there are breaking api changes. i just want to raise attention to the churn daily releases creates downstream

@cpanato
Copy link
Member

cpanato commented Nov 15, 2024

once a week may be fine to release an on-demand

Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
@luhring luhring enabled auto-merge November 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants