Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): validate expected commit before passing to git-checkout pipeline #1667

Merged
merged 2 commits into from
Nov 23, 2024
Merged

fix(pipeline): validate expected commit before passing to git-checkout pipeline #1667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26ad08
fix(pipeline): validate expected commit before passing to git-checkou…
89luca89 Nov 22, 2024
11e1a73
fix linting
89luca89 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/build/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,14 @@ func validateWith(data map[string]string, inputs map[string]config.Input) (map[s
return data, fmt.Errorf("checksum input %q for pipeline, invalid length", k)
}
}
if k == "expected-commit" && data[k] != "" {
if !matchValidShaChars(data[k]) {
return data, fmt.Errorf("expectec commit %q for pipeline contains invalid characters", k)
}
if len(data[k]) != 40 {
return data, fmt.Errorf("expected commit %q for pipeline, invalid length", k)
}
}

if v.Required && data[k] == "" {
return data, fmt.Errorf("required input %q for pipeline is missing", k)
Expand Down
Loading