Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qemu): improve logging, make connection check less spammy #1701

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

89luca89
Copy link
Contributor

This improves a bit the logging, making it less noisy and adhere to other runners' output.
Also, improve a bit the connection check, which gets very spammy on less performant machines (or cross compiles) where IO timeout was set way too low.

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@89luca89 89luca89 requested review from smoser and imjasonh December 13, 2024 16:48
@89luca89
Copy link
Contributor Author

The Test fail seems related to numpy:

2024/12/13 18:04:11 INFO populating workspace /tmp/melange-workspace-936571740 from ./test-fixtures
2024/12/13 18:04:11 INFO ImgRef = /tmp/melange-guest-3338514633
2024/12/13 18:04:11 INFO running the main test pipeline
2024/12/13 18:04:11 INFO running step "python/test"
2024/12/13 18:04:11 WARN Traceback (most recent call last): uses=python/test
2024/12/13 18:04:11 WARN   File "<string>", line 1, in <module> uses=python/test
2024/12/13 18:04:11 WARN ModuleNotFoundError: No module named 'numpy' uses=python/test
2024/12/13 18:04:11 INFO ERROR: failed to test package. the test environment has been preserved:

Not related to this PR but maybe a temporary thing with the python package?

@89luca89 89luca89 enabled auto-merge December 13, 2024 17:08
89luca89 and others added 2 commits December 13, 2024 18:31
Co-authored-by: Jon Johnson <jonjohnsonjr@gmail.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment inline.

pkg/container/qemu_runner.go Outdated Show resolved Hide resolved
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
@89luca89 89luca89 requested a review from smoser December 17, 2024 17:21
@89luca89 89luca89 merged commit ad24227 into chainguard-dev:main Dec 17, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants