📝 👷 docs: ci: Document and update syncronizing lockfile with release #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realised a better idea that to use the action with jbang is to assume mvn is setup for the release (as it is probably needed to build it, and to run |
LogFlames
changed the title
LogFlames
changed the title
LogFlames
force-pushed
the
1042-document-potential-issue-where-lockfile-for-tagged-release-commit-contains-snapshot-version
branch
from
097c2a3 to
8b4f797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1042.
The project itself currently runs maven-lockfile directly using
jbangin the relase action. Some more thought has to be put into if/how the maven-lockfile/action.yml should/could be used instead. It would be more convenient as it automatically set up the environment needed with java, maven and jbang. But during the release action it must be able to be run on newly created (not yet pushed) branches, on updated pom.xml's that are not commited, etc.