improved some algebra dispatch

chakravala · May 2, 2021 · bdbc054 · bdbc054 · chakravala · May 2, 2021
1 parent 6fbe29b
commit bdbc054
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/composite.jl b/src/composite.jl
@@ -9,6 +9,7 @@ export exph, log_fast, logh_fast
 @inline Base.expm1(t::SubManifold{V,0}) where V = Simplex{V}(ℯ-1)
 @inline Base.expm1(t::T) where T<:TensorGraded{V,0} where V = Simplex{Manifold(t)}(AbstractTensors.expm1(value(T<:TensorTerm ? t : scalar(t))))
 
+Base.expm1(t::Chain) = expm1(MultiVector(t))
 function Base.expm1(t::T) where T<:TensorAlgebra
     V = Manifold(t)
     S,term,f = t,(t^2)/2,norm(t)

diff --git a/src/products.jl b/src/products.jl
@@ -542,7 +542,7 @@ for side ∈ (:left,:right)
                     out = zeros(svec(N,G,Any))
                     D = diffvars(V)
                     for k ∈ 1:binomial(N,G)
-                        val = :(b.v[$k])
+                        val = :(conj(b.v[$k]))
                         @inbounds p = $p(V,ib[k])
                         v = $(c≠h ? :($pnp(V,ib[k],val)) : :val)
                         v = typeof(V)<:Signature ? (p ? :($SUB($v)) : v) : Expr(:call,MUL,p,v)
@@ -559,7 +559,7 @@ for side ∈ (:left,:right)
                         if val≠0
                             @inbounds p = $$p(V,ib[k])
                             v = $(c≠h ? :($$pn(V,ib[k],val)) : :val)
-                            v = typeof(V)<:Signature ? (p ? $SUB(v) : v) : $MUL(p,v)
+                            v = conj(typeof(V)<:Signature ? (p ? $SUB(v) : v) : $MUL(p,v))
                             @inbounds setblade!(out,v,complement(N,ib[k],D,P),Val{N}())
                         end
                     end
@@ -595,7 +595,7 @@ for side ∈ (:left,:right)
                             @inbounds val = m.v[bs[g]+i]
                             if val≠0
                                 v = $(c≠h ? :($$pn(V,ib[i],val)) : :val)
-                                v = typeof(V)<:Signature ? ($$p(V,ib[i]) ? $SUB(v) : v) : $$p(V,ib[i])*v
+                                v = conj(typeof(V)<:Signature ? ($$p(V,ib[i]) ? $SUB(v) : v) : $$p(V,ib[i])*v)
                                 @inbounds setmulti!(out,v,complement(N,ib[i],D,P),Val{N}())
                             end
                         end