Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve rectangular domain module code in Dyno #25684

Draft
wants to merge 61 commits into
base: main
Choose a base branch
from
Draft

Resolve rectangular domain module code in Dyno #25684

wants to merge 61 commits into from

Commits on Sep 19, 2024

  1. Add test for correct ambiguity between procs 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d247e1b View commit details
    Browse the repository at this point in the history

  2. Add test for resolving 'this' on shadowing var 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    aca1839 View commit details
    Browse the repository at this point in the history

  3. Repeat lookupIdentifier as non-called if no methods found 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    85e26cb View commit details
    Browse the repository at this point in the history

  4. Only repeat lookupIdentifier when result is ambiguous 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    11f4034 View commit details
    Browse the repository at this point in the history

  5. Clarify comment and var name 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    155cf65 View commit details
    Browse the repository at this point in the history

  6. Check for any procs, not just methods 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    778c513 View commit details
    Browse the repository at this point in the history

  7. Resolve to innermost identifier for called var case 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2d01907 View commit details
    Browse the repository at this point in the history

  8. Check for vars only rather than absence of functions 

    To avoid edge cases with module names

Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fe82d15 View commit details
    Browse the repository at this point in the history

  9. Remove redundant calculation of resolvingCalledIdent 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    11dd1ee View commit details
    Browse the repository at this point in the history

  10. Add TODO for a more principled solution 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0cfd280 View commit details
    Browse the repository at this point in the history

  11. Test and handle similar shadowing formal case 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    377ec06 View commit details
    Browse the repository at this point in the history

  12. Test resolving a dependently-typed field in method 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    547d28d View commit details
    Browse the repository at this point in the history

  13. Instantiate generic class types with actual type 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9f1723a View commit details
    Browse the repository at this point in the history

  14. Refactor to include manageability check 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a727ef5 View commit details
    Browse the repository at this point in the history

  15. Revert accidental autoformat changes 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d15cc59 View commit details
    Browse the repository at this point in the history

  16. Add tests for type field/parenless in signature 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e770a61 View commit details
    Browse the repository at this point in the history

  17. Fix setting instantiated receiver type in instantiateSignature 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3496931 View commit details
    Browse the repository at this point in the history

  18. Fix setting receiver type in Resolver setup 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6350456 View commit details
    Browse the repository at this point in the history

  19. Test generic receiver with parenless type proc case 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    623d6a8 View commit details
    Browse the repository at this point in the history

  20. Delay qualified field resolution on generic types 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3c3103b View commit details
    Browse the repository at this point in the history

  21. Delay unqualified field resolution on generic types 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b88d4a7 View commit details
    Browse the repository at this point in the history

  22. Add test that forwarding 'except' doesn't exlude others 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ba70058 View commit details
    Browse the repository at this point in the history

  23. Fix resolving forwarding with VisibilityClauses 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    33cbe9a View commit details
    Browse the repository at this point in the history

  24. Move 'init' call comment closer to where it's created 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f2551e4 View commit details
    Browse the repository at this point in the history

  25. Rewrite 'new dmap' to 'new _distribution' 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ae90479 View commit details
    Browse the repository at this point in the history

  26. Add 'new' resolution for domains 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ac85a84 View commit details
    Browse the repository at this point in the history

  27. Replace hardcoded IDs of special records in return-type-inference 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6e0db7a View commit details
    Browse the repository at this point in the history

  28. Remove more redundant hardcoded symbol names of special types 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6104d8f View commit details
    Browse the repository at this point in the history

  29. Assert domain is domain type in testDomains 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    62edf66 View commit details
    Browse the repository at this point in the history

  30. Rewrite resolveSpecialCall if/else as a short-circuiting disjunction 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4bee01e View commit details
    Browse the repository at this point in the history

  31. Add 'domain' case to resolveSpecialKeywordCall 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2c476d7 View commit details
    Browse the repository at this point in the history

  32. Resolve 'domain(?)' as 'domain' 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cd76840 View commit details
    Browse the repository at this point in the history

  33. Pass 'dist' arg with placeholder type 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3e1f587 View commit details
    Browse the repository at this point in the history

  34. Resolve and use real 'defaultDist' type 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    09af8a4 View commit details
    Browse the repository at this point in the history

  35. Remove workaround in chpl__defaultDistInitPrivate 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    15b2bd9 View commit details
    Browse the repository at this point in the history

  36. Move instead of copy actuals 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0ad4199 View commit details
    Browse the repository at this point in the history

  37. Switch domain resolve from chpl__buildDomainRuntimeType to new _domain 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    794f773 View commit details
    Browse the repository at this point in the history

  38. More work on getting new _domain working 

    Most significantly including proper lookup of the type of defaultDist

Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6a34bac View commit details
    Browse the repository at this point in the history

  39. Add TODO to put runAndTrackErrors back 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5f3c941 View commit details
    Browse the repository at this point in the history

  40. Remove leftover breakpoints 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0f3e436 View commit details
    Browse the repository at this point in the history

  41. Use init call as type rather than value 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    be4821b View commit details
    Browse the repository at this point in the history

  42. Add domain literal type resolution 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fb6c824 View commit details
    Browse the repository at this point in the history

  43. Fix comment about object -> RootClass 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    29a770c View commit details
    Browse the repository at this point in the history

  44. Set up ctFromSubs for _domain 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3565b80 View commit details
    Browse the repository at this point in the history

  45. Set INIT_RECEIVER kind for generated _domain.init call 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7361d45 View commit details
    Browse the repository at this point in the history

  46. Include _instance in DomainType subsittutions to fix init issue 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4523975 View commit details
    Browse the repository at this point in the history

  47. Fix resolving domain type expressions via resolved init receiver 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7d8e9d9 View commit details
    Browse the repository at this point in the history

  48. Restore use of runAndTrackErrors 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5acc293 View commit details
    Browse the repository at this point in the history

  49. Get basic testing with standard domain module 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    568b55d View commit details
    Browse the repository at this point in the history

  50. Update testing from stridable -> strides 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ec73826 View commit details
    Browse the repository at this point in the history

  51. Add and use RUNTIME_TYPE AssociatedAction for domain type expressions 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8af1d4b View commit details
    Browse the repository at this point in the history

  52. Remove compiler-generated domain methods 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cdd57ba View commit details
    Browse the repository at this point in the history

  53. Re-enable testing for some basic domain methods 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    053b7dc View commit details
    Browse the repository at this point in the history

  54. Re-enable testDomains .type testing 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4f4f088 View commit details
    Browse the repository at this point in the history

  55. Enable forwarding on DomainTypes 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1b052a7 View commit details
    Browse the repository at this point in the history

  56. Adjust and re-enable _domain.pid testing 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    70c32e0 View commit details
    Browse the repository at this point in the history

  57. Re-enable domain iteration testing 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9a07752 View commit details
    Browse the repository at this point in the history

  58. Remove unused variable 

    Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    58f56db View commit details
    Browse the repository at this point in the history

  59. Remove use of minimal ChapelArray in testArrays 

    Also remove test-minimal-modules.h as now empty and unused

Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2bbaae2 View commit details
    Browse the repository at this point in the history

  60. Revert "Remove use of minimal ChapelArray in testArrays" 

    This reverts commit a953fb3.

Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    585188e View commit details
    Browse the repository at this point in the history

  61. Use real ChapelDomain in testArrays, with module code errors ignored 

    Also disable associative array testing until associative domains are
fixed

Signed-off-by: Anna Rift <anna.rift@hpe.com>
    @riftEmber
    riftEmber committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1c7598e View commit details
    Browse the repository at this point in the history