Remove Makefiles in compiler/ and frontend/ #25907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of relying on Makefiles. --- Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
--- Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
--- Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
mppf
force-pushed
the
compiler-makefile-removal
branch
from
451c931
to
126a45b
Compare
arezaii
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
I don't use tags, but I generated them and found only those in ./compilers/TAGS differed.
Of those, it appears there are several new symbols included, but no symbols missing. I think the new symbols come from specific files that were excluded from compiler/AST/Makefile.share, and the "prims-specific variables", although there are probably others because there are about 80 new symbols now vs. before.
I did verify that I could use tags to navigate as such:
$ make TAGS=1
$ cd compiler
$ vim -t LibraryFileWriter
Which opened vim and took me to the definition of LibraryFileWriter
Full list of new symbols
EOF_TOK
GatherToplevelSymbols
Line
_GNU_SOURCE
_POSIX_C_SOURCE
argtypes
buf_read
build_data
catstr
charp
complexSqrt128
complexSqrt64
computeCommonPrefix
computeSymbolNames
containedFilePaths
declare_data
define_data
doLoadLocations
dupstr
forv_Line
fp
gatherTopLevelModuleNames
gatherTopLevelModules
getLlvmPgasPluginInfo
getLocationMap
get_lines
hfp
invalidFileError
llvmGetPassPluginInfo
load
loadAstQuery
loadGenCodeModule
loadLibraryFileQuery
loadLlvmModuleImpl
loadLocations
loadLocationsQuery
loadModuleAst
loadModuleSection
loadModuleSectionQuery
loadSourceAst
makeDoubleComplex
makeFloatComplex
my_aligned_alloc
my_strerror_r
nargs
negToZero
noteSymbolForTable
noteToplevelSymbolsForTable
nres
openAndMap
openFile
padToAlign
pos
readHeaders
readLocationEntries
readLocationGroup
readLocationPaths
readModuleAst
readModuleSection
registerLibrary
rettypes
setGeneratedCode
setSourcePaths
setupHelper
string
summarize
symbolIdLess
writeAllSections
writeAst
writeGenCode
writeHeader
writeLocationEntries
writeLocationGroup
writeLocations
writeLongStrings
writeModuleSection
writeSymbolTable
zeroNegToNegOne
~LibraryFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since PR #20920, we have been using
cmaketo build the compiler and frontend library. However, we have left the oldMakefiles lying around and have continued to maintain them as we add or remove files. These Makefiles have been unused, except for in TAGS support.This PR changes the TAGS support to use a
findcommand to gather source files in these directories and then removes these Makefiles that are now completely unused.Reviewed by @arezaii - thanks!