Dyno fix forwarding with except excluding other symbols
#25931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
10 tasks
dlongnecke-cray
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in which a
forwardingstatement with anexceptoronlyclause wouldn't actually forward anything.This was due to
resolveForwardingExprslooking for the type of the expression in theForwardingDeclwith the assumption it'd be anIdentifier. That didn't work whenexcept/onlyis present as then theForwardingDeclcontains aVisibilityClausewhich doesn't get a type resolved. Fixed by extracting the type of theVisibilityClause's base symbol in that case instead.Also add a test that this case now works.
Note that we still don't support proper functionality of forwarding with
except/onlyin Dyno at this time; this just makes it so those clauses don't prevent the forwarding entirely.Resolves https://github.com/Cray/chapel-private/issues/6688.
[reviewer info placeholder]
Testing: