Dyno: fix decls with tuple type expressions and initialization expressions #25951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Cray/chapel-private/issues/6385; prior to this PR, the following program:
Produced an error:
The (chapel syntax) output is quite confusing in the error message, but the difference between the specified type and the actual type are the intents of the components. On the left hand site we have a 'type' tuple, but on the right we have a value tuple.
There is already logic on
main
to adjust the type of the declaration at the end to mark the tuple components 'var' or 'ref', etc. However, the type-value mismatch happens while the type of the declaration is being inferred, before the final adjustment. The solution seems to be to adjust the type of the tuple's components using the same rules as "usual" (described, I believe, in the specification here). So, this PR extracts the "adjustment" process, runs it once on the type expression to ensure it's compatible with the value, then again on the final type.Reviewed by @benharsh -- thanks!
Testing