Add support for LLVM 19 #25964
Merged
Add support for LLVM 19 #25964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
mppf
approved these changes
Sep 23, 2024
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
added a commit
that referenced
this pull request
Nov 5, 2024
jabraham17
added a commit
that referenced
this pull request
Nov 5, 2024
Fixes some compiler build errors with LLVM 11 introduced by #25964 Tested that `make check` works with LLVM 11. [Reviewed by @riftEmber]
jabraham17
added a commit
that referenced
this pull request
Nov 5, 2024
Fixes an include path issue caused by #25964. #25964 changed all `-I` for LLVM includes into a `-isystem` so that they would not be subject to `-Werror`, which could break compiler builds irreparably for some versions of LLVM. However, `-isystem` perturbs the header search order, meaning if LLVM is already installed to a system include path then other stuff may break. The fix is to use `-isystem-after` instead of `-isystem`, however this is a clang only flag. `-idirafter` has the same effect but exists in both [GCC](https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html#Options-for-Directory-Search) and [clang](https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-idirafter-arg), so that is used in this PR. Tested that the compiler builds on both a system where LLVM is installed to a system path and a system where it is not. [Reviewed by @riftEmber]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to use Chapel with LLVM 19
Testing:
start_test test/llvm/abi/aarch64/on ARM64start_test test/gpu/nativewith cuda 12start_test test/gpu/nativewith cuda 12 with OFI[Reviewed by @mppf]