Fix disambiguation bug in dyno resolver #25967
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug in the dyno disambiguation mechanism that was comparing
QualifiedType
s (including thekind
) instead of justType
s without the kind.I discovered this while trying to implement the
_owned
toowned
mapping, where choices were being ignored because one wasconst ref
and one wasref
.Talking with @mppf, it seems like we should probably not be making that comparison including the kind in
testArgMapping
.