Add new lint rule flavor, @location_rule
#26191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2024
jabraham17
added a commit
that referenced
this pull request
Dec 10, 2024
Expands chplcheck rule capabilities by allowing rules to specify extra settings to make them more configurable. This allows users to specify additional arguments to rules to better configure them to suit their needs. No new rules are added in this PR, this just lays the foundation for future work (see #26191) [Reviewed by @DanilaFe]
jabraham17
force-pushed
the
add-freeform
branch
from
41bd7dc to
dc7fdb0
Compare
DanilaFe
reviewed
Dec 13, 2024
DanilaFe
approved these changes
Dec 13, 2024
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
force-pushed
the
add-freeform
branch
from
fec05b5 to
3b7eb0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new chplcheck lint rule flavor, called
@location_rule. This allows rule authors and users to write purely text based lint rules.This PR then uses that functionality to implement a proper LineLength lint rule that defaults to 80 characters, but can be configured as users desire.
Subsumes #25938 and resolves #25220
[Reviewed by @DanilaFe]