Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-geospatial? #3

Open
jeffp123 opened this issue Dec 25, 2024 · 2 comments · May be fixed by #2
Open

Support for non-geospatial? #3

jeffp123 opened this issue Dec 25, 2024 · 2 comments · May be fixed by #2
Labels
feature New feature or request

Comments

@jeffp123
Copy link

I have made a small PR that adds a Supercluster::new_non_geospatial that functions otherwise like a regular Supercluster instance, except it will not apply conversions to/from lat/lng coordinates.

As noted in the PR description, there is still a little bit of updating yet to do, to improve the code comments and testing, but first I would like to first present my approach here and see if there are any comments/suggestions:
https://github.com/chargetrip/supercluster-rs/pull/2/files

@slavik-pastushenko
Copy link
Collaborator

Hey @jeffp123!

Thanks for contributing!
I left a few comments, please take a look whenever you can.

@jeffp123
Copy link
Author

awesome, thank you! I will update in the next day or so.

@slavik-pastushenko slavik-pastushenko linked a pull request Dec 26, 2024 that will close this issue
6 tasks
@slavik-pastushenko slavik-pastushenko added the feature New feature or request label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants