Add enable_features_if_present to PhysicalDevice #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
spnda
reviewed
Apr 22, 2024
add_required_extension_features takes a reference now, but the docs indicated it took a pointer.
This allows the set_required_features_11/12/13 to take a reference instead of a value. Applications should set the sType, vk-bootstrap shouldn't be doing that for apps.
charles-lunarg
force-pushed
the
allow_enabling_optional_features
branch
2 times, most recently
from
ad41fec
to
3e57bee
Compare
Allows users to enable features if they are present, getting back a bool telling them whether the feature is supported and will be enabled on the device. Also: * Removes redundant VkPhysicalDeviceFeatures2 struct in vkb::PhysicalDevice. * Adds test copying of details when creating a VkDevice so that test can check what features were actually enabled on the device. * Creates GenericFeatureChain struct for managing pNext chains. * Allow multiple calls to set_require_features by combining the fields
charles-lunarg
force-pushed
the
allow_enabling_optional_features
branch
from
3e57bee
to
3616eb3
Compare
This was
linked to
issues
Apr 26, 2024
|
I'm going to go ahead and merge - additional features can always be added later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to enable features if they are present, getting back a bool telling them whether the feature is supported and will be enabled on the device.
Fixes #269