Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enable_features_if_present to PhysicalDevice #273

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Add enable_features_if_present to PhysicalDevice #273

merged 3 commits into from
Apr 26, 2024

Commits on Apr 26, 2024

  1. Fix getting started docs using pointer instead of reference 

    add_required_extension_features takes a reference now, but the docs
indicated it took a pointer.
    @charles-lunarg
    charles-lunarg committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0233d11 View commit details
    Browse the repository at this point in the history

  2. Assert that set_required_features sTypes are set 

    This allows the set_required_features_11/12/13 to take a reference instead
of a value. Applications should set the sType, vk-bootstrap shouldn't be
doing that for apps.
    @charles-lunarg
    charles-lunarg committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2934b5c View commit details
    Browse the repository at this point in the history

  3. Add enable_features_if_present to PhysicalDevice 

    Allows users to enable features if they are present, getting back a bool
telling them whether the feature is supported and will be enabled on the
device.

Also:
* Removes redundant VkPhysicalDeviceFeatures2 struct in vkb::PhysicalDevice.
* Adds test copying of details when creating a VkDevice so that test can check
what features were actually enabled on the device.
* Creates GenericFeatureChain struct for managing pNext chains.
* Allow multiple calls to set_require_features by combining the fields
    @charles-lunarg
    charles-lunarg committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3616eb3 View commit details
    Browse the repository at this point in the history