Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add are_extension_features_present to PhysicalDevice #278

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Add are_extension_features_present to PhysicalDevice #278

merged 5 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Add are_extension_features_present to PhysicalDevice

    @n0F4x @charles-lunarg
    n0F4x authored and charles-lunarg committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    04caa61 View commit details
    Browse the repository at this point in the history

  2. Fix typos in function documentation

    @n0F4x @charles-lunarg
    n0F4x authored and charles-lunarg committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    6726d19 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary feature checks

    @n0F4x @charles-lunarg
    n0F4x authored and charles-lunarg committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    82287d8 View commit details
    Browse the repository at this point in the history

  4. Make are_extension_features_present handle mismatched lists 

    The original implementation only worked if the requested features
had the same length. It'll now handle that properly.
    @charles-lunarg
    charles-lunarg committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a9ee87b View commit details
    Browse the repository at this point in the history

  5. Add negative test for are_extension_feature_present 

    Didn't handle the case where some fields were supported but others weren't.
    @charles-lunarg
    charles-lunarg committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5a99008 View commit details
    Browse the repository at this point in the history