fix client signal level bug, add client signal-to-noise ratio #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfieber
commented
Dec 18, 2023
•
jfieber
commented
- The client signal was being reported as dBm when it is, in fact a derived "connection quality" expressed as a percentage. This changes the metric name to be clear and not cause confusion over the same metric showing different semantics over time.
- Add the client signal-to-noise ratio
- Address what may be the issue in no hostname showing for some LAN clients #22. I'm not convinced falling back on Name in the absence of HostName is quite correct though. Maybe we should always use Name, and add the sometimes-there-sometimes-not HostName as a separate label? That would be more consistent with Omada's data model.
- Add a different taken on generating the metrics description table in the Readme.
The HostName client field seems somewhat unreliable in practice. Fall back on the Name field if it is absent. Maybe a fix for charlie-haley#22
jfieber
changed the title
This should guarantee docs matching the code, and replace the defunct metric-markdown-table.sh script.
| @@ -48,6 +48,12 @@ func Run() { | |||
| os.Exit(0) | |||
| return nil | |||
| }}, | |||
| {Name: "mdocs", Aliases: []string{"md"}, Usage: "prints the metric docs.", | |||
There was a problem hiding this comment.
Could you update the Makefile to use this command instead of the script?
Remaining buglet: the version and mdocs commands shouldn’t require host, username and password arguments.
Formerly the client metrics `client` label was populated with the hostname provided by the controller. The hostname parameter is not reliably present. This change populates the `client` label with the name value from the controller, and moves the hostname to a separate `hostname` label. It is not 100% clear how Omada sets the name. A best guess is: - If the name explicitly set a name in the Omada UI, that. - If no name is explicitly set, and a hostname has been determined, use the hostname. - If no name is explicitly set, and no hostname has been determined, us the mac address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.