Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

CEM-2546- PartySizeSelector #396

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

CEM-2546- PartySizeSelector #396

wants to merge 7 commits into from

Conversation

pavldavid
Copy link
Contributor

If you click anything on the right, everything on the left should be orange.

image

import {PersonFill} from '@styled-icons/bootstrap/PersonFill'

export interface IPartySizeSelector {
person?: React.ForwardRefExoticComponent<React.RefAttributes<SVGSVGElement>>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing documentation

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be updated with in meeting feedback

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation, need to use theme for colors, architecture might be a bit off

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, docs for props missing

@ralph-dev
Copy link
Member

You've committed to the wrong branch @pavldavid

@pavldavid
Copy link
Contributor Author

pavldavid commented Nov 30, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants