This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Lakehead - CEM-2602 Profile list with counter #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percypie
commented
Nov 24, 2021
percypie
commented
ralph-dev
suggested changes
Nov 24, 2021
|
|
||
| `; | ||
|
|
||
| //todo Make location change with amount of profiles (currently having issues trying to make Featured profile card not generate a new line without being able to edit it) |
ralph-dev
reviewed
Nov 24, 2021
|
I assumed I wasn't allowed to edit the existing component, if I can edit the existing component then I can fix this very easily |
ralph-dev
suggested changes
Nov 24, 2021
| {renderProfileCircles()} | ||
| <FeaturedProfile icon key={ADD_USER_ICON_KEY} background="grey" /> | ||
| </Container> | ||
| <CountContainer>{profileData.length}</CountContainer> |
There was a problem hiding this comment.
This needs to be optional
Prop && Jsx
ralph-dev
reviewed
Nov 25, 2021
| @@ -20,10 +20,13 @@ export interface IProfile { | |||
|
|
|||
| export interface IFeaturedProfilesCardProps { | |||
| profileData: IProfile[]; | |||
| counterBool: boolean; | |||
There was a problem hiding this comment.
Documentation of Props goes here not on the component. You are doucmenting the type
ralph-dev
reviewed
Nov 25, 2021
| } | ||
|
|
||
| export const FeaturedProfilesCard: React.FC<IFeaturedProfilesCardProps> = ({ | ||
| profileData, | ||
| profileData, //the array of profiles to be displayed | ||
| counterBool, //if true, the profile counter is displayed, and if false, the counter is not displayed |
There was a problem hiding this comment.
docs should not be on this line, put in TypeScript
ralph-dev
approved these changes
Nov 25, 2021
ralph-dev
reviewed
Nov 26, 2021
| Basic.args = { | ||
| profileData: profiles, | ||
| counterBool: false, |
There was a problem hiding this comment.
Don't put Types in the Name
We dont say NameString, we just say Name.
Rename this to isCounterShowing or isCounterDisplayed or isProfileCountShowing
the prefix is denotes a Boolean value
ralph-dev
approved these changes
Nov 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.