Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read fieldType from currently processed type #321

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Nov 7, 2024

When using nested where filter we should read field return type from that nested type, not top-level type.

Test plan

{
    proposals(
    where: {
      cancelled: false
      space_in: [
        "0x03ced313394107c43a2f36b63262c00a6422231ac229dc4cedd0d9928d8c3c5f"
      ]
      metadata_: { title_contains_nocase: "" }
    }
  ) {
    id
  }
}

When using nested where filter we should read field return type
from that nested type, not top-level type.
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Sekhmet Sekhmet merged commit 68e3c7b into master Nov 7, 2024
1 check passed
@Sekhmet Sekhmet deleted the sekhmet/nested-return-type branch November 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants