Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin endpoint for mocks creation should return 400 if the input is not valid #80

Open
zhouzhuojie opened this issue Jun 13, 2020 · 1 comment
Open

Admin endpoint for mocks creation should return 400 if the input is not valid #80

zhouzhuojie opened this issue Jun 13, 2020 · 1 comment

Comments

@zhouzhuojie
Copy link
Contributor

I think a few functions may need to bubble up the errors so that we can prevent invalid input early on. Incidents like an invalid yaml input could potentially crash the openmock server and may need manual interaction from the redis server.

openmock/pkg/admin/convert.go

Line 62 in 68fadf5

func swaggerToOpenmockMock(swagger model.Mock) (om openmock.Mock) {

@zhouzhuojie
Copy link
Contributor Author

cc @sesquipedalian-dev @elan-devops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhouzhuojie