Prevents long URLs from breaking the layout. #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: #29 This commit changes the `span.link-text` element to a block layout, which allows us to apply the CSS `text-overflow: ellipsis;` rule to long URLs. I've also removed the now unnecessary <br> tag in the post template, as block layout elements do not require manual line breaks.
|
Just wondering how do you test this? I've tried it on Mobile emulation mode in Chrome, it's still kinda breaks the layout 😞 |
|
It still pushes the comment button away.
|
|
Hmm... I only made changes to the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #29
This commit changes the
span.link-textelement to a block layout,which allows us to apply the CSS
text-overflow: ellipsis;rule tolong URLs. I've also removed the now unnecessary
<br>tag in the posttemplate, as block layout elements do not require manual line breaks.