Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saml troubleshooting doc update #8175

Closed
wants to merge 6 commits into from
Closed

saml troubleshooting doc update #8175

wants to merge 6 commits into from

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented Aug 30, 2023

🔩 Description: What code changed, and why?

https://chefio.atlassian.net/browse/CHEF-5686

⛓️ Related Resources

👍 Definition of Done

Updated Doc for SAML related error

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@iamazzeez iamazzeez requested review from Dmaddu and a team August 30, 2023 08:09
@iamazzeez iamazzeez self-assigned this Aug 30, 2023
@iamazzeez iamazzeez requested a review from a team as a code owner August 30, 2023 08:09
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit b0090dc
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64f020c117515400089f6505
😎 Deploy Preview https://deploy-preview-8175--chef-automate.netlify.app/automate/saml
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Aug 30, 2023
Copy link
Collaborator

@Dmaddu Dmaddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the preview link generated. Lines are not indented properly

@iamazzeez iamazzeez requested a review from Dmaddu August 31, 2023 05:04
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iamazzeez iamazzeez requested a review from a team August 31, 2023 10:05
@iamazzeez iamazzeez closed this Sep 4, 2023
@iamazzeez
Copy link
Contributor Author

iamazzeez commented Sep 4, 2023

No more needed, issue is user specific, config depends on Azure AD settings, which may be different for different user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants