-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS Post Verification #8176
Merged
Merged
GCS Post Verification #8176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verify_private pipeline: https://buildkite.com/chef/chef-automate-main-verify-private/builds/32097 |
Dmaddu
force-pushed
the
feature/CHEF-5280
branch
from
September 2, 2023 12:07
9c85c30
to
4ed8761
Compare
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
Dmaddu
force-pushed
the
sanju/GCS_Post_Verification
branch
from
September 4, 2023 04:58
c100dad
to
8d6330a
Compare
Dmaddu
approved these changes
Sep 4, 2023
SahithiMy
pushed a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com>
9 tasks
Dmaddu
added a commit
that referenced
this pull request
Sep 13, 2023
…ket.gs (#8133) * Added GCP config struct Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Added gcp values Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * gcs values for batch check (#8150) Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> * added values for config parser (#8141) * added values for config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * modified gcs values in config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Added test cases Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * modified field name Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * handled location empty case Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Pr comments Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * pipeline trigger Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * pipeline fix Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * pipeline fix Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> --------- Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> * pull and generate for gcp config Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com> * Retreved changes and removed duplicate variables Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * retrieved mapping config parser changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Create The API for checking the GCS config (#8159) * added values for config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * modified gcs values in config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Added test cases Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Pr comments Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Modification based on the credential file path Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Pipeline trigger Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * moving changes in json file Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * moving changes in json file Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * moving rebase conflict changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * added values for config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * modified gcs values in config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Pr comments Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Initial commit for GCP APi Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Added GetGCPConnection test Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Removed rebased not required changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Just a save Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * API check connection success Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * API done, test cases remain Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Removed copied changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Resolution msg correction and rebased Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Unit test cases for the handler Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Mocked tests for the service Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Added UUID and gcpUtils Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Modified mock Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Added changes based on mock Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Done with API changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Improvised test cases Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Removed unused variables Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Improvised code Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Moved utils to services Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Contex added, modified the return type of NewGCPUtils() func Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * updated mod file Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * updating the code Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com> * updating to internal logger Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com> * If connection fails than dont check for access Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> --------- Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: dmaddu <dmaddu@progress.com> * GCS Post Verification (#8176) Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com> * Sahithi/chef 5614 (#8167) * added values for config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * modified gcs values in config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Added test cases Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Pr comments Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Modification based on the credential file path Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Pipeline trigger Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * moving changes in json file Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * moving changes in json file Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * moving rebase conflict changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * added values for config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * modified gcs values in config parser Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Pr comments Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Initial commit for GCP APi Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Removed rebased not required changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Just a save Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Removed copied changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Mocked tests for the service Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Added UUID and gcpUtils Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Modified mock Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Added changes based on mock Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Done with API changes Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Improvised test cases Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Removed unused variables Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Improvised code Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Moved utils to services Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Contex added, modified the return type of NewGCPUtils() func Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * updating the code Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com> * Mapped config parser Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * Modification based on the credential file path Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * trigger check for gcs Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * adding location Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * rebasing Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * rebasing conflicts Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * fixed conflict issues Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * rebasing Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> --------- Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: Pappu Kumar <pappu.kumar@progress.com> Co-authored-by: dmaddu <dmaddu@progress.com> * fixing config gen verify flow (#8211) * fixing config gen verify flow Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Improved test cases Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * testcase fix Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * changes for unmarshall Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * testcase fix Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> --------- Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> * Credential check before gcp backup check (#8215) * fixing config gen verify flow Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * testcase fix Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * changes for unmarshall Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> * Credential check before gcp backup check Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> * repo health pipeline corrected Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> --------- Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> --------- Signed-off-by: Pappu Kumar <pappu.kumar@progress.com> Signed-off-by: SahithiMy <sahithi.mylangam@progress.com> Signed-off-by: “SanjuPal01” <sanju.sanju@progress.com> Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com> Co-authored-by: SahithiMy <sahithi.mylangam@progress.com> Co-authored-by: SahithiMy <98326242+SahithiMy@users.noreply.github.com> Co-authored-by: “SanjuPal01” <sanju.sanju@progress.com> Co-authored-by: dmaddu <dmaddu@progress.com> Co-authored-by: Sanju Pal <101255220+SanjuPal01@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Now we are getting GCS config in post deployment.
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-5625
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Video Link: https://progresssoftware-my.sharepoint.com/:v:/g/personal/ssanju_progress_com/EV1Eb4lfF_5IlaLSvEvcZ7EBtPSw7dDYbUYDMp-P6KcK7A?e=oaIaob