Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEF-4690: Updated test cases as per latest code change. #8179

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

agmathur
Copy link
Collaborator

🔩 Description: What code changed, and why?

Updated test cases as per latest code change.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-4690

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • [x ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • [ x] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • [ x] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • [ x] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • [ x] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • [x ] Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Agam Mathur <agmathur@progress.com>
@agmathur agmathur merged commit 84ae5eb into Aadesh/License_service Aug 31, 2023
4 checks passed
@agmathur agmathur deleted the agam/CHEF-4690_1 branch August 31, 2023 08:56
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

arunjn-progress pushed a commit that referenced this pull request Aug 31, 2023
* License usage service created

Signed-off-by: AadeshNichite <anichite@progress.com>

* license service updated

Signed-off-by: AadeshNichite <anichite@progress.com>

* License tracking service call added after signin

Signed-off-by: AadeshNichite <anichite@progress.com>

* time related changes added

Signed-off-by: AadeshNichite <anichite@progress.com>

* condition added for JS library load check

Signed-off-by: AadeshNichite <anichite@progress.com>

* minor change added

Signed-off-by: AadeshNichite <anichite@progress.com>

* updated with global JS library path

Signed-off-by: AadeshNichite <anichite@progress.com>

* CHEF-4690: Added test cases for LicenseUsageService. (#8151)

* CHEF-4690: Added test cases for LicenseUsageService.

Signed-off-by: Agam Mathur <agmathur@progress.com>

* CHEF-4690: Injected LicenseUsageService.

Signed-off-by: Agam Mathur <agmathur@progress.com>

---------

Signed-off-by: Agam Mathur <agmathur@progress.com>

* JS library called dynamically and added new payload values

Signed-off-by: AadeshNichite <anichite@progress.com>

* new payload values added

Signed-off-by: AadeshNichite <anichite@progress.com>

* remove unwanted space

Signed-off-by: AadeshNichite <anichite@progress.com>

* new urls added

Signed-off-by: AadeshNichite <anichite@progress.com>

* new url added and change minor logic

Signed-off-by: AadeshNichite <anichite@progress.com>

* changes added for async js pull

Signed-off-by: AadeshNichite <anichite@progress.com>

* changes added

Signed-off-by: AadeshNichite <anichite@progress.com>

* lint issues fixed for license usage service

Signed-off-by: AadeshNichite <anichite@progress.com>

* CHEF-4690: Updated test cases as per latest code change. (#8179)

Signed-off-by: Agam Mathur <agmathur@progress.com>

* new changes added

Signed-off-by: AadeshNichite <anichite@progress.com>

* localstorage name change

Signed-off-by: AadeshNichite <anichite@progress.com>

* fixed lint issues

Signed-off-by: vinay sharma <vsharma@chef.io>

* add minor changes

Signed-off-by: vinay sharma <vsharma@chef.io>

* CHEF-4690: Test case change after variable removal.

Signed-off-by: Agam Mathur <agmathur@progress.com>

* minor changes

Signed-off-by: vinay sharma <vsharma@chef.io>

* value change

Signed-off-by: AadeshNichite <anichite@progress.com>

---------

Signed-off-by: AadeshNichite <anichite@progress.com>
Signed-off-by: Agam Mathur <agmathur@progress.com>
Signed-off-by: vinay sharma <vsharma@chef.io>
Co-authored-by: Agam Mathur <108087313+agmathur@users.noreply.github.com>
Co-authored-by: vinay sharma <vsharma@chef.io>
Co-authored-by: Agam Mathur <agmathur@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant