Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify private fix 2 #8575

Closed
wants to merge 88 commits into from
Closed

Verify private fix 2 #8575

wants to merge 88 commits into from

Conversation

iamazzeez
Copy link
Contributor

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

daveaugustus and others added 30 commits August 29, 2024 13:16
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
* removing unnecessary changes

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* fixing cert error message

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

* updating the code

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

---------

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
* Adding authn-service test cases fix

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Fixing unit test cases for infra proxy, function call  not needed

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Remving fault lines

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding changes for require statements

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Fix

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding string in conatins

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding test cases fix

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Changing equal from object to string

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Changing equal from object to string

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Changing equal from object to string

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

---------

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
daveaugustus and others added 24 commits September 12, 2024 11:12
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: iamazzeez <aazeez@progress.com>
* Restored license control

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Added go proxy

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Updated mod

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* modified test case

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Added error check for server instance

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* grpc

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* fixed mod

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

---------

Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Co-authored-by: daveaugustus <pappu.kumar@progress.com>
* license scout uncommented

Signed-off-by: iamazzeez <aazeez@progress.com>

* license scout fix

Signed-off-by: iamazzeez <aazeez@progress.com>

* Ruby 3.0.4 with Postgres 14 segmentation fault

Signed-off-by: iamazzeez <aazeez@progress.com>

* lienses added

Signed-off-by: iamazzeez <aazeez@progress.com>

* lienses added

Signed-off-by: iamazzeez <aazeez@progress.com>

* lienses added

Signed-off-by: iamazzeez <aazeez@progress.com>

* lienses added

Signed-off-by: iamazzeez <aazeez@progress.com>

* repo health fix

Signed-off-by: iamazzeez <aazeez@progress.com>

* repo health fix added exceptions for golang

Signed-off-by: iamazzeez <aazeez@progress.com>

* Dave/verify private 2 (#8586)

* modified pacnic check

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Update storage.go

* undefined log

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Test

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Revised the test cases

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Modified test log

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

---------

Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Co-authored-by: daveaugustus <pappu.kumar@progress.com>

---------

Signed-off-by: iamazzeez <aazeez@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Co-authored-by: Augusutus <36985548+daveaugustus@users.noreply.github.com>
Co-authored-by: daveaugustus <pappu.kumar@progress.com>
@iamazzeez iamazzeez force-pushed the verify_private_fix_2 branch 2 times, most recently from d0a400f to 7e5834b Compare September 12, 2024 06:08
Signed-off-by: iamazzeez <aazeez@progress.com>

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

@iamazzeez
Copy link
Contributor Author

#8590 this PR has changes.

@iamazzeez iamazzeez closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants