Abdul/go upgrade 2 #8590

iamazzeez · 2024-09-12T10:53:35Z

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

I have read the CONTRIBUTING document.
All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

Tests added/updated? (all new code needs new tests)
Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

netlify · 2024-09-12T10:53:53Z

👷 Deploy Preview for chef-automate processing.

Name	Link
🔨 Latest commit	`d269e82`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/6704d670e378d000083252ed

Dmaddu · 2024-10-07T10:01:07Z

A new submodule googleapis added. Do we need that one?

.studio/common

Dmaddu · 2024-10-07T09:29:23Z

buf.yaml

@@ -467,4 +467,4 @@ breaking:
    - config/workflow_server/config_request.proto
    - config/workflow_nginx/config_request.proto
    - config/workflow_server/config_request.proto
-
+    - protovendor/github.com/envoyproxy/protoc-gen-validate/validate/validate.proto


Do we need this change?

Dmaddu · 2024-10-07T09:34:18Z

components/automate-gateway/eventfeed/events_test.go

-			).DoAndReturn(func(c context.Context, action *event_feed_api.FeedRequest) (*event_feed_api.FeedResponse, error) {
-				return &event_feed_api.FeedResponse{}, nil
-			})
+			//mockFeedServiceClient.EXPECT().GetFeed(


Any specific reason for commenting these lines?

Dmaddu · 2024-10-07T09:35:07Z

components/automate-gateway/gateway/helpers_internal_test.go

-					return mockAuthorizationClient, nil
-				},
-			)
+			//mockClientsFactory.EXPECT().AuthorizationClient().DoAndReturn(


components/ingest-service/pipeline/processor/runs_project_tagger_test.go

components/license-control-service/pkg/storage/storage.go

integration/helpers/testing.sh

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

* Restored license control Signed-off-by: daveaugustus <pappu.kumar@progress.com> * Added go proxy Signed-off-by: daveaugustus <pappu.kumar@progress.com> * Updated mod Signed-off-by: daveaugustus <pappu.kumar@progress.com> * modified test case Signed-off-by: daveaugustus <pappu.kumar@progress.com> * Added error check for server instance Signed-off-by: daveaugustus <pappu.kumar@progress.com> * grpc Signed-off-by: daveaugustus <pappu.kumar@progress.com> * fixed mod Signed-off-by: daveaugustus <pappu.kumar@progress.com> --------- Signed-off-by: daveaugustus <pappu.kumar@progress.com> Co-authored-by: daveaugustus <pappu.kumar@progress.com>

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Signed-off-by: iamazzeez <aazeez@progress.com>

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Signed-off-by: iamazzeez <aazeez@progress.com>

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

sonarqube-for-infrastructure-prod · 2024-10-08T07:24:07Z

Quality Gate failed

Failed conditions
3 New issues
49.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

iamazzeez requested review from daveaugustus, Dmaddu and YashviJain01 September 12, 2024 10:53

iamazzeez self-assigned this Sep 12, 2024

daveaugustus approved these changes Sep 13, 2024

View reviewed changes

iamazzeez mentioned this pull request Sep 16, 2024

Abdul/go upgrade fix #8591

Closed

9 tasks

Dmaddu requested changes Oct 7, 2024

View reviewed changes

daveaugustus self-requested a review October 7, 2024 17:45

SahithiMy and others added 12 commits October 8, 2024 11:18

testCurl8

eb3b9c2

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

testCurl8

16d1bb3

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

testCurl8

aa0e7cf

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

nginx pipeline fix

bd7727e

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

automate-cluster-ctl pipeline fix

811635b

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

automate-backend-deployment pipeline fix

ae43ace

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

removed pinned version

157b624

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

Rebasing

7d8cc5a

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

GOlang update to version 1.22.0

062c38b

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

golang v1.22.5

e55b265

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Modified Go version in all the files

d998a12

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Pipeline check

9d68183

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

daveaugustus and others added 24 commits October 8, 2024 11:21

added go.sum dependency

5248416

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

license scout fix

71956f3

Signed-off-by: iamazzeez <aazeez@progress.com>

lienses added

f8c8679

Signed-off-by: iamazzeez <aazeez@progress.com>

lienses added

80ab3f0

Signed-off-by: iamazzeez <aazeez@progress.com>

lienses added

620c9be

Signed-off-by: iamazzeez <aazeez@progress.com>

lienses added

be1d5ab

Signed-off-by: iamazzeez <aazeez@progress.com>

repo health fix

df79585

Signed-off-by: iamazzeez <aazeez@progress.com>

modified pacnic check

5817aea

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Update storage.go

04c391e

undefined log

34c1d85

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Test

621645e

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Revised the test cases

1b8621c

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Modified test log

cd5b51f

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

all go upgrade latest fixes

05b8658

Signed-off-by: iamazzeez <aazeez@progress.com>

removed manual go install

969cb71

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

to build sh

b5b4c0e

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

to build sh

3c5830b

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

to build openjdk

b5a897a

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

PR comments

b0dbd4a

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Review fixes

358efda

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Re commented the code

8c043ae

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Re commented the code

2060b5e

Signed-off-by: daveaugustus <pappu.kumar@progress.com>

regenerating the proto files

885d5f7

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Dmaddu force-pushed the abdul/go_upgrade_2 branch from 13ce7b0 to 885d5f7 Compare October 8, 2024 06:11

removing the empty directory

d269e82

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

Dmaddu approved these changes Oct 9, 2024

View reviewed changes

Dmaddu merged commit b584a0b into main Oct 9, 2024
10 of 13 checks passed

Dmaddu deleted the abdul/go_upgrade_2 branch October 9, 2024 06:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Abdul/go upgrade 2 #8590

Abdul/go upgrade 2 #8590

iamazzeez commented Sep 12, 2024

netlify bot commented Sep 12, 2024 •

edited

Loading

Dmaddu commented Oct 7, 2024

Dmaddu Oct 7, 2024

Dmaddu Oct 7, 2024

Dmaddu Oct 7, 2024

sonarqube-for-infrastructure-prod bot commented Oct 8, 2024

Abdul/go upgrade 2 #8590

Abdul/go upgrade 2 #8590

Conversation

iamazzeez commented Sep 12, 2024

🔩 Description: What code changed, and why?

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

netlify bot commented Sep 12, 2024 • edited Loading

👷 Deploy Preview for chef-automate processing.

Dmaddu commented Oct 7, 2024

Dmaddu Oct 7, 2024

Choose a reason for hiding this comment

Dmaddu Oct 7, 2024

Choose a reason for hiding this comment

Dmaddu Oct 7, 2024

Choose a reason for hiding this comment

sonarqube-for-infrastructure-prod bot commented Oct 8, 2024

Quality Gate failed

netlify bot commented Sep 12, 2024 •

edited

Loading