-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the check port changes for chef-managed database for automate ha #8613
Conversation
Signed-off-by: punitmundra <pmundra@progress.com>
👷 Deploy Preview for chef-automate processing.
|
# Compare major versions | ||
if (( major1 > major2 )); then | ||
echo "$installed_version is greater than $airgap_bundle_version" | ||
isSkipRequired=true | ||
elif (( major1 < major2 )); then | ||
echo "$airgap_bundle_version is greater than $installed_version, proceeding for upgrade" | ||
else | ||
# Compare minor versions | ||
if (( minor1 > minor2 )); then | ||
echo "$installed_version is greater than $airgap_bundle_version" | ||
isSkipRequired=true | ||
elif (( minor1 < minor2 )); then | ||
echo "$airgap_bundle_version is greater than $installed_version, proceeding for upgrade" | ||
else | ||
# Compare patch versions | ||
if (( patch1 > patch2 )); then | ||
echo "$installed_version is greater than $airgap_bundle_version" | ||
isSkipRequired=true | ||
elif (( patch1 < patch2 )); then | ||
echo "$airgap_bundle_version is greater than $installed_version, proceeding for upgrade" | ||
else | ||
echo "Both versions are equal" | ||
fi | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do some unit testing by putting it in a function ?
@@ -55,10 +55,10 @@ backend automate_postgresql | |||
{{~#if ../cfg.resolvers.nameservers }} | |||
server-template {{node.address}} 8 {{node.address}}:{{node.port}} check resolvers pgdns init-addr none resolve-prefer ipv4 | |||
{{else}} | |||
server {{node.address}} {{node.address}}:{{node.port}} maxconn {{../cfg.max_connections}} check port 6432 | |||
server {{node.address}} {{node.address}}:{{node.port}} maxconn {{../cfg.max_connections}} {{~#if ../cfg.chef_manage_db }} check port 6432 {{~/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put the maxconn into the if condition, since earlier the maxconn was not present for customer managed database
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Quality Gate passedIssues Measures |
…#8613) * first set of changes in pg-gateway Signed-off-by: punitmundra <pmundra@progress.com> * change the config name from chef_manage_db -> automate_ha_chef_manage_pg Signed-off-by: punitmundra <pmundra@progress.com> * change the config name from chef_manage_db -> automate_ha_chef_manage_pg Signed-off-by: punitmundra <pmundra@progress.com> * bump the package Signed-off-by: punitmundra <pmundra@progress.com> * bump the packages Signed-off-by: punitmundra <pmundra@progress.com> --------- Signed-off-by: punitmundra <pmundra@progress.com>
🔩 Description: What code changed, and why?
https://progresssoftware.atlassian.net/browse/CHEF-16071
https://progresssoftware.atlassian.net/browse/CHEF-16072
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable