Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix for certificate template script in Automate HA #8616

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

punitmundra
Copy link
Collaborator

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: punitmundra <pmundra@progress.com>
Copy link

netlify bot commented Sep 27, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 04077ed
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/66f6894b83b26200082cf163

Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
Signed-off-by: punitmundra <pmundra@progress.com>
@punitmundra punitmundra merged commit 2a43e42 into main Sep 27, 2024
10 of 12 checks passed
@punitmundra punitmundra deleted the intergration-test branch September 27, 2024 10:44
kalroy pushed a commit that referenced this pull request Oct 8, 2024
* typo fix for certificate error

Signed-off-by: punitmundra <pmundra@progress.com>

* add testcase for semver

Signed-off-by: punitmundra <pmundra@progress.com>

* fix path

Signed-off-by: punitmundra <pmundra@progress.com>

* fix path

Signed-off-by: punitmundra <pmundra@progress.com>

---------

Signed-off-by: punitmundra <pmundra@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants