Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask subdomain of chef server api_fqdn before sending to telemetry #3883

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sreepuramsudheer
Copy link
Contributor

Description

[Please describe what this change achieves]

Issues Resolved

https://chefio.atlassian.net/browse/CHEF-14975
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
Signed-off-by: sreepuramsudheer <ssudheer@progress.com>
@sreepuramsudheer sreepuramsudheer requested review from a team as code owners August 19, 2024 14:02
Copy link

netlify bot commented Aug 19, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit fcc837e
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/66c35077a6ab3800086c96d5

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@jashaik jashaik changed the base branch from main to ssudheer/CHEF-12624 August 20, 2024 07:34
@@ -66,7 +66,7 @@ start_link() ->
gen_server:start_link({local, ?MODULE}, ?MODULE, [], []).

init(_Config) ->
ReportingUrl = envy:get(chef_telemetry, reporting_url, ?DEFAULT_REPORTING_URL, string),
ReportingUrl = envy:get(chef_telemetry, reporting_time, ?DEFAULT_REPORTING_TIME, Fun),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@sreepuramsudheer sreepuramsudheer force-pushed the ssudheer/CHEF-12624 branch 4 times, most recently from 076da0f to 693273a Compare August 21, 2024 05:38
Base automatically changed from ssudheer/CHEF-12624 to main August 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants