Changes to preprocessor functions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some pre-processor function calls for instruction encoder identities such as `ZO`. Previously the `pre_default()` pre processor function was called to check if the operand sizes are the same; However in this special edge case where there are *no* operands, we can simply ignore this behaviour.
The previous name of `pre_default` seemed *too general* and infered that this is the default behavior of the assembler, however desc- ribing the pre processor function as `same_operand_sizes` more ac- curatly encapsulates the expected behavior instead of needing to skim over the code before adding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request describes the changes of removing and renaming of redundant pre processor functions, namely the
pre_defaultpre processor function has been removed from manyOP_ZOencoder identities due to its redundant nature, causing it to be 'doubled up' with theop_identify()function.