-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing guide changes #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit added new information about how to add support for a new instruction in the Jas assembler, however, this commit only descitbes the changes for adding the instruction encoder reference table aka the `insr_encode_table_t` as seen in `instruction.h` and the corri- sponding source file
This commit fixed spelling errors and beautified code example on the instruction encoder table as well as the formatting of the explanation caption for the corresponding example code.
Squash 3 commits with similar published changes
This commit added a new section into the contributions guide, this section explained the steps and implications involved to add a instruction to the `instructions` enum after defining the struct
This comit added the code section termination symbol to terminate the demo code, since the termination symbol was forgotten in previous commit number b9e87d1
In markdown, if there are whitesapces before and/or after the bold operator - `**`, the formatting will be omitted for some reason :((
This commit shows the final changes that has finished the 'Adding s- upport for a new instruction to the assembler' section.
This commit added rthe maintaince section that explained how the maintaince works as a team in the Jas project as well as how they can become and renouce maintainer status
Added previously missing link for maintainers which was added in commit number d1e79dc
This commit added the section for explaining how to contribute a new encoder to the Jas assembler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request describes the changes that finally concludes the writing of the Jas contribution guide, in particular, this Pull request adds in the common changes and items for developers such as adding new assembler instructions and encoder functions.