Added pre-processor function for ENC_ZO identities
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull has added the `no_operands` pre-processor function, this function aims to prevent callers and users accidentally passing operands into instructions which carries the `ENC_ZO` identity in which they do not require any operands. Furthermore, this pull (albiet not very the niche with this pull's "agenda") has also corrected the `nop` instruction which previously had the instruction encoder table values switched around, casuing the opcode to be read as the opcode extention and the opcode extention to be read as the *real opcode*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull has added the
no_operandspre-processor function, this function aims to prevent callers and users accidentally passing operands into instructions which carries theENC_ZOidentity in which they do not require any operands.Furthermore, this pull (albiet not very the niche with this pull's "agenda") has also corrected the
nopinstruction which previously had the instruction encoder table values switched around, casuing the opcode to be read as the opcode extention and the opcode extention to be read as the real opcode