WIP: linting fixes

chevdor · Aug 19, 2021 · 607a793 · 607a793
1 parent e492b09
commit 607a793
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/lib/src/lib.rs b/lib/src/lib.rs
@@ -112,7 +112,7 @@ mod tests {
 	fn it_fetches_the_version() {
 		let tag = fetch_image_tag().unwrap();
 		println!("current tag = {:?}", tag);
-		assert!(tag.len() > 0);
+		assert!(!tag.is_empty());
 	}
 
 	#[test]

diff --git a/lib/src/runner.rs b/lib/src/runner.rs
@@ -142,7 +142,7 @@ impl Runner {
 
 		output
 			.map(|o| o.stdout)
-			.map(|v| String::from_utf8(v).unwrap_or("".into()))
+			.map(|v| String::from_utf8(v).unwrap_or_else(|_| "".into()))
 			.map(|s| serde_json::from_str(&s).unwrap_or(Value::Null))
 			.map_err(|e| e.to_string())
 	}

diff --git a/lib/src/rustc_version.rs b/lib/src/rustc_version.rs
@@ -10,7 +10,7 @@ pub enum RustcVersion {
 	// Dev(String),
 }
 
-pub struct Error;
+// pub struct Error;
 
 impl FromStr for RustcVersion {
 	type Err = String;

diff --git a/lib/src/version.rs b/lib/src/version.rs
@@ -1,7 +1,6 @@
 use crate::rustc_version::RustcVersion;
 use semver::Version;
 use serde::{Deserialize, Serialize};
-use std::str::FromStr;
 
 /// A structure describing the output the info command
 #[derive(Debug, Serialize, Deserialize)]