From a93decfc20c958df6e8f90074b244b0ae13c0a3b Mon Sep 17 00:00:00 2001 From: Fabrizio Duroni Date: Thu, 24 Oct 2024 15:52:51 +0200 Subject: [PATCH] Clean up docc broken link + tests (#107) :rocket: * Clean up static property + docc broken link * Added linux tests --- .github/workflows/build-linux.yml | 1 + Demo/Demo.xcodeproj/project.pbxproj | 13 ++++++++- ID3TagEditor.xcodeproj/project.pbxproj | 6 ++--- .../ID3TagEditorAcceptanceTest.swift | 27 ------------------- .../ID3TagEditorWriteReadAcceptanceTest.swift | 6 ----- .../PaddingAdderUsingNullCharTest.swift | 4 --- .../Common/PaddingRemoverUsingTrimming.swift | 4 --- ...teArrayAdapterUsingUnsafePointerTest.swift | 4 --- ...ID3AttachedPicturesFrameCreatorsTest.swift | 9 ------- .../ID3DiscPositionFrameCreatorTest.swift | 5 ---- .../ID3FrameContentSizeCalculatorTest.swift | 5 ---- Tests/Create/ID3FrameFlagsCreatorTest.swift | 5 ---- ...ID3FrameFromStringContentCreatorTest.swift | 4 --- Tests/Create/ID3FrameHeaderCreatorTest.swift | 4 --- ...D3FrameWithIntegerContentCreatorTest.swift | 5 ---- ...ID3FrameWithStringContentCreatorTest.swift | 5 ---- ...ramesWithLocalizedContentCreatorTest.swift | 5 ---- Tests/Create/ID3GenreFrameCreatorTest.swift | 5 ---- .../ID3ISO88591StringToByteAdapterTest.swift | 4 --- .../Create/ID3LocalizedFrameCreatorTest.swift | 6 ----- ...ID3RecordingDateTimeFrameCreatorTest.swift | 5 ---- ...ID3RecordingDayMonthFrameCreatorTest.swift | 6 ----- Tests/Create/ID3TagCreatorTest.swift | 6 ----- Tests/Create/ID3TimestampCreatorTest.swift | 9 ------- .../ID3TrackPositionFrameCreatorTest.swift | 5 ---- .../ID3UTF16StringToByteAdapterTest.swift | 4 --- Tests/Frame/ID3FrameConfigurationTest.swift | 4 --- Tests/Mp3/Mp3FileReaderTest.swift | 10 ------- Tests/Mp3/Mp3FileWriterTest.swift | 4 --- ...tureFrameContentParsingOperationTest.swift | 5 ---- .../ID3DiscPositionStringAdapterTest.swift | 6 ----- .../Parse/ID3FrameContentSizeParserTest.swift | 6 ----- Tests/Parse/ID3FrameSizeParserTest.swift | 5 ---- Tests/Parse/ID3GenreStringAdapterTest.swift | 7 ----- ...D3LocalizedFrameParsingOperationTest.swift | 5 ---- Tests/Parse/ID3PictureTypeAdapterTest.swift | 7 ----- .../ID3RecordingTimestampOperationTest.swift | 5 ---- ...ID3StringContentParsingOperationTest.swift | 8 ------ Tests/Parse/ID3TagSizeParserTest.swift | 5 ---- Tests/Parse/ID3TagVersionParserTest.swift | 6 ----- .../ID3TrackPositionStringAdapterTest.swift | 6 ----- Tests/Tag/ID3TagPresenceTest.swift | 7 ----- Tests/Tag/ID3TagTest.swift | 5 ---- 43 files changed, 15 insertions(+), 248 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 5046ce7f..ace265d5 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -22,6 +22,7 @@ jobs: - name: Build Linux framework run: | swift build + swift test - name: Build Linux Demo run: | cd Demo/Demo\ Ubuntu diff --git a/Demo/Demo.xcodeproj/project.pbxproj b/Demo/Demo.xcodeproj/project.pbxproj index 4cc2fa87..520a2580 100644 --- a/Demo/Demo.xcodeproj/project.pbxproj +++ b/Demo/Demo.xcodeproj/project.pbxproj @@ -379,8 +379,9 @@ 452832E72044D28E00458375 /* Project object */ = { isa = PBXProject; attributes = { + BuildIndependentTargetsInParallel = YES; LastSwiftUpdateCheck = 1600; - LastUpgradeCheck = 1200; + LastUpgradeCheck = 1600; ORGANIZATIONNAME = "Fabrizio Duroni"; TargetAttributes = { 45966C942CBACF5000F841E7 = { @@ -583,6 +584,7 @@ CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; CODE_SIGN_IDENTITY = "Mac Developer"; COPY_PHASE_STRIP = NO; + DEAD_CODE_STRIPPING = YES; DEBUG_INFORMATION_FORMAT = dwarf; ENABLE_STRICT_OBJC_MSGSEND = YES; ENABLE_TESTABILITY = YES; @@ -645,6 +647,7 @@ CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; CODE_SIGN_IDENTITY = "Mac Developer"; COPY_PHASE_STRIP = NO; + DEAD_CODE_STRIPPING = YES; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; ENABLE_NS_ASSERTIONS = NO; ENABLE_STRICT_OBJC_MSGSEND = YES; @@ -689,6 +692,7 @@ "@executable_path/Frameworks", ); LOCALIZATION_PREFERS_STRING_CATALOGS = YES; + MACOSX_DEPLOYMENT_TARGET = 11.0; MARKETING_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_FAST_MATH = YES; @@ -726,6 +730,7 @@ "@executable_path/Frameworks", ); LOCALIZATION_PREFERS_STRING_CATALOGS = YES; + MACOSX_DEPLOYMENT_TARGET = 11.0; MARKETING_VERSION = 1.0; MTL_FAST_MATH = YES; PRODUCT_BUNDLE_IDENTIFIER = "it.chicio.Demo-tvOS"; @@ -766,6 +771,7 @@ "@executable_path/Frameworks", ); LOCALIZATION_PREFERS_STRING_CATALOGS = YES; + MACOSX_DEPLOYMENT_TARGET = 11.0; MARKETING_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_FAST_MATH = YES; @@ -806,6 +812,7 @@ "@executable_path/Frameworks", ); LOCALIZATION_PREFERS_STRING_CATALOGS = YES; + MACOSX_DEPLOYMENT_TARGET = 11.0; MARKETING_VERSION = 1.0; MTL_FAST_MATH = YES; PRODUCT_BUNDLE_IDENTIFIER = "it.chicio.Demo-iOS"; @@ -830,6 +837,7 @@ CODE_SIGN_STYLE = Automatic; COMBINE_HIDPI_IMAGES = YES; CURRENT_PROJECT_VERSION = 1; + DEAD_CODE_STRIPPING = YES; DEVELOPMENT_ASSET_PATHS = "\"Demo macOS/Preview Content\""; DEVELOPMENT_TEAM = 5Y4K7JX2AU; ENABLE_HARDENED_RUNTIME = YES; @@ -867,6 +875,7 @@ CODE_SIGN_STYLE = Automatic; COMBINE_HIDPI_IMAGES = YES; CURRENT_PROJECT_VERSION = 1; + DEAD_CODE_STRIPPING = YES; DEVELOPMENT_ASSET_PATHS = "\"Demo macOS/Preview Content\""; DEVELOPMENT_TEAM = 5Y4K7JX2AU; ENABLE_HARDENED_RUNTIME = YES; @@ -914,6 +923,7 @@ "@executable_path/Frameworks", ); LOCALIZATION_PREFERS_STRING_CATALOGS = YES; + MACOSX_DEPLOYMENT_TARGET = 11.0; MARKETING_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; MTL_FAST_MATH = YES; @@ -953,6 +963,7 @@ "@executable_path/Frameworks", ); LOCALIZATION_PREFERS_STRING_CATALOGS = YES; + MACOSX_DEPLOYMENT_TARGET = 11.0; MARKETING_VERSION = 1.0; MTL_FAST_MATH = YES; PRODUCT_BUNDLE_IDENTIFIER = "it.chicio.Demo-watchOS"; diff --git a/ID3TagEditor.xcodeproj/project.pbxproj b/ID3TagEditor.xcodeproj/project.pbxproj index fa2ceff5..36ad07bd 100644 --- a/ID3TagEditor.xcodeproj/project.pbxproj +++ b/ID3TagEditor.xcodeproj/project.pbxproj @@ -50,7 +50,6 @@ 455CF98B2340C4E1004C880A /* PULL_REQUEST_TEMPLATE.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = PULL_REQUEST_TEMPLATE.md; sourceTree = ""; }; 45925B99253B4EB4001C8D4F /* codecov.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; path = codecov.yml; sourceTree = ""; }; 45925B9A253B5277001C8D4F /* codecov.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; path = codecov.yml; sourceTree = ""; }; - 459ABE822CBBCFAC00DCCD69 /* ID3TagEditor.docc */ = {isa = PBXFileReference; lastKnownFileType = folder.documentationcatalog; path = ID3TagEditor.docc; sourceTree = ""; }; 45AB7193204AD842004A2239 /* Package.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Package.swift; sourceTree = ""; }; 45AB7194204AD842004A2239 /* LICENSE.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = LICENSE.md; sourceTree = ""; }; 45AB7195204AD842004A2239 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = ""; }; @@ -193,7 +192,6 @@ 452831BB2044C40700458375 = { isa = PBXGroup; children = ( - 459ABE822CBBCFAC00DCCD69 /* ID3TagEditor.docc */, 45925B99253B4EB4001C8D4F /* codecov.yml */, 45541C25205999A20025A8BF /* CHANGELOG.md */, 455CF98A2340C4D7004C880A /* CODE_OF_CONDUCT.md */, @@ -1022,7 +1020,7 @@ SKIP_INSTALL = YES; SWIFT_VERSION = 6.0; TARGETED_DEVICE_FAMILY = 3; - TVOS_DEPLOYMENT_TARGET = 12.0; + TVOS_DEPLOYMENT_TARGET = 15.0; }; name = Debug; }; @@ -1056,7 +1054,7 @@ SKIP_INSTALL = YES; SWIFT_VERSION = 6.0; TARGETED_DEVICE_FAMILY = 3; - TVOS_DEPLOYMENT_TARGET = 12.0; + TVOS_DEPLOYMENT_TARGET = 15.0; VALIDATE_PRODUCT = YES; }; name = Release; diff --git a/Tests/Acceptance/ID3TagEditorAcceptanceTest.swift b/Tests/Acceptance/ID3TagEditorAcceptanceTest.swift index c95d9acd..0c6a18ba 100644 --- a/Tests/Acceptance/ID3TagEditorAcceptanceTest.swift +++ b/Tests/Acceptance/ID3TagEditorAcceptanceTest.swift @@ -895,33 +895,6 @@ struct ID3TagEditorAcceptanceTest { #expect((id3Tag?.frames[.comment(.eng)] as? ID3FrameWithLocalizedContent)?.contentDescription == "") #expect((id3Tag?.frames[.comment(.eng)] as? ID3FrameWithLocalizedContent)?.content == "ÜberStandard - UberNet.org") } - - static let allTests = [ - ("testFailWrongFilePathFilePath", testFailWrongFilePathFilePath), - ("testReadTagV2", testReadTagV2), - ("testParseTagV3", testParseTagV3), - ("testReadTagV4", testReadTagV4), - ("testReadTagV4WithImage", testReadTagV4WithImage), - ("testReadAsMp3", testReadAsMp3), - ("testReadCorruptedFile", testReadCorruptedFile), - ("testReadUtf16String", testReadUtf16String), - ("testWriteTagV2", testWriteTagV2), - ("testWriteTagV3WhenItAlreadyExists", testWriteTagV3WhenItAlreadyExists), - ("testWriteTagV3WithJpg", testWriteTagV3WithJpg), - ("testWriteTagV3WithPng", testWriteTagV3WithPng), - ("testWriteTagV3WithCustomPathThatDoesNotExists", testWriteTagV3WithCustomPathThatDoesNotExists), - ("testWriteTagV3WithSamePath", testWriteTagV3WithSamePath), - ("testWriteTagV3WithAdditionalData", testWriteTagV3WithAdditionalData), - ("testWriteTagV3ToMp3AsData", testWriteTagV3ToMp3AsData), - ("testWriteTagV4", testWriteTagV4), - ("testWriteTagV4WithPng", testWriteTagV4WithPng), - ("testWriteTagV4SynchsafeIntegers", testWriteTagV4SynchsafeIntegers), - ("testWriteUnsynchronisedLyrics", testWriteUnsynchronisedLyrics), - ("testWriteNewFramesV2", testWriteNewFramesV2), - ("testWriteNewFramesV3", testWriteNewFramesV3), - ("testWriteNewFramesV4", testWriteNewFramesV4), - ("testCommentWithUTF8EncodingAndNoContentDescription", testCommentWithUTF8EncodingAndNoContentDescription) - ] } // swiftlint:enable type_body_length diff --git a/Tests/Acceptance/ID3TagEditorWriteReadAcceptanceTest.swift b/Tests/Acceptance/ID3TagEditorWriteReadAcceptanceTest.swift index 0a420317..e5befcf4 100644 --- a/Tests/Acceptance/ID3TagEditorWriteReadAcceptanceTest.swift +++ b/Tests/Acceptance/ID3TagEditorWriteReadAcceptanceTest.swift @@ -502,12 +502,6 @@ struct ID3TagEditorWriteReadAcceptanceTest { #expect(tagReader.iTunesPodcastID() == "PodcastID V4") #expect(tagReader.iTunesPodcastKeywords() == "PodcastKeywords V4") } - - static let allTests = [ - ("testReadWritev2", testReadWritev2), - ("testReadWritev3", testReadWritev3), - ("testReadWritev4", testReadWritev4) - ] } // swiftlint:enable type_body_length diff --git a/Tests/Common/PaddingAdderUsingNullCharTest.swift b/Tests/Common/PaddingAdderUsingNullCharTest.swift index c4f03c3f..fec054f6 100644 --- a/Tests/Common/PaddingAdderUsingNullCharTest.swift +++ b/Tests/Common/PaddingAdderUsingNullCharTest.swift @@ -16,8 +16,4 @@ struct PaddingAdderUsingNullCharTest { #expect(contentWithPadding == [0x1, 0x1, 0x0]) } - - static let allTests = [ - ("testAddPadding", testAddPadding) - ] } diff --git a/Tests/Common/PaddingRemoverUsingTrimming.swift b/Tests/Common/PaddingRemoverUsingTrimming.swift index d86b258a..2861052c 100644 --- a/Tests/Common/PaddingRemoverUsingTrimming.swift +++ b/Tests/Common/PaddingRemoverUsingTrimming.swift @@ -15,8 +15,4 @@ struct PaddingRemoverUsingTrimmingTest { PaddingRemoverUsingTrimming().removeFrom(string: "\0\0\0simple string\0\0\0") ) } - - static let allTests = [ - ("testRemovePadding", testRemovePadding) - ] } diff --git a/Tests/Common/UInt32ToByteArrayAdapterUsingUnsafePointerTest.swift b/Tests/Common/UInt32ToByteArrayAdapterUsingUnsafePointerTest.swift index 1291a6e2..ee329133 100644 --- a/Tests/Common/UInt32ToByteArrayAdapterUsingUnsafePointerTest.swift +++ b/Tests/Common/UInt32ToByteArrayAdapterUsingUnsafePointerTest.swift @@ -15,8 +15,4 @@ struct UInt32ToByteArrayAdapterUsingUnsafePointerTest { [0x11, 0x22, 0x33, 0x44] ) } - - static let allTests = [ - ("testAdapt32BitUnsignedInteger", testAdapt32BitUnsignedInteger) - ] } diff --git a/Tests/Create/ID3AttachedPicturesFrameCreatorsTest.swift b/Tests/Create/ID3AttachedPicturesFrameCreatorsTest.swift index 30315ad1..57c754cf 100644 --- a/Tests/Create/ID3AttachedPicturesFrameCreatorsTest.swift +++ b/Tests/Create/ID3AttachedPicturesFrameCreatorsTest.swift @@ -146,15 +146,6 @@ struct ID3AttachedPicturesFramesCreatorTest { 0x00, 0x04, 0x00, 0x10, 0x10] ) } - - static let allTests = [ - ("frameCreationWithJpgForVersion2", frameCreationWithJpgForVersion2), - ("frameCreationWithJpgForVersion3", frameCreationWithJpgForVersion3), - ("frameCreationWithPngForAnotherTypeOfCover", frameCreationWithPngForAnotherTypeOfCover), - ("frameCreationWithPngForVersion2", frameCreationWithPngForVersion2), - ("frameCreationWithPngForVersion3", frameCreationWithPngForVersion3), - ("noFrameCreationWhenThereIsNoImage", noFrameCreationWhenThereIsNoImage) - ] } diff --git a/Tests/Create/ID3DiscPositionFrameCreatorTest.swift b/Tests/Create/ID3DiscPositionFrameCreatorTest.swift index bd22a5a9..67a30e56 100644 --- a/Tests/Create/ID3DiscPositionFrameCreatorTest.swift +++ b/Tests/Create/ID3DiscPositionFrameCreatorTest.swift @@ -43,9 +43,4 @@ struct ID3DiscPositionFrameCreatorTest { #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testFrameCreationWhenThereIsADiscPosition", testFrameCreationWhenThereIsADiscPosition), - ("testNoFrameCreationWhenThereIsNoDiscPosition", testNoFrameCreationWhenThereIsNoDiscPosition) - ] } diff --git a/Tests/Create/ID3FrameContentSizeCalculatorTest.swift b/Tests/Create/ID3FrameContentSizeCalculatorTest.swift index 1af87b70..8189dc77 100644 --- a/Tests/Create/ID3FrameContentSizeCalculatorTest.swift +++ b/Tests/Create/ID3FrameContentSizeCalculatorTest.swift @@ -39,9 +39,4 @@ struct ID3FrameContentSizeCalculatorTest { #expect(size == [0x3, 0x2]) } - - static let allTests = [ - ("testContentCalculateSizeForVersion2", testContentCalculateSizeForVersion2), - ("testContentCalculateSizeForVersion3", testContentCalculateSizeForVersion3) - ] } diff --git a/Tests/Create/ID3FrameFlagsCreatorTest.swift b/Tests/Create/ID3FrameFlagsCreatorTest.swift index 5f19f040..570a453b 100644 --- a/Tests/Create/ID3FrameFlagsCreatorTest.swift +++ b/Tests/Create/ID3FrameFlagsCreatorTest.swift @@ -16,9 +16,4 @@ struct ID3FrameFlagsCreatorTest { @Test func testFlagsForVersion2() { #expect(ID3FrameFlagsCreator().createFor(version: .version2) == []) } - - static let allTests = [ - ("testFlagsForVersion2", testFlagsForVersion2), - ("testFlagsForVersion3", testFlagsForVersion3) - ] } diff --git a/Tests/Create/ID3FrameFromStringContentCreatorTest.swift b/Tests/Create/ID3FrameFromStringContentCreatorTest.swift index 0de8d62f..ef0658bb 100644 --- a/Tests/Create/ID3FrameFromStringContentCreatorTest.swift +++ b/Tests/Create/ID3FrameFromStringContentCreatorTest.swift @@ -23,8 +23,4 @@ struct ID3FrameFromStringContentCreatorTest { #expect(frameBytes == [0x01, 0x02] + "test".utf16ToBytes) } - - static let allTests = [ - ("testCreatorFrameFromStringContent", testCreatorFrameFromStringContent) - ] } diff --git a/Tests/Create/ID3FrameHeaderCreatorTest.swift b/Tests/Create/ID3FrameHeaderCreatorTest.swift index 09351ccc..a7aac160 100644 --- a/Tests/Create/ID3FrameHeaderCreatorTest.swift +++ b/Tests/Create/ID3FrameHeaderCreatorTest.swift @@ -19,8 +19,4 @@ struct ID3FrameHeaderCreatorTest { #expect(header == [UInt8]("USLT".utf8) + [0x11, 0x00]) } - - static let allTests = [ - ("create", create) - ] } diff --git a/Tests/Create/ID3FrameWithIntegerContentCreatorTest.swift b/Tests/Create/ID3FrameWithIntegerContentCreatorTest.swift index 0befab80..a54c746a 100644 --- a/Tests/Create/ID3FrameWithIntegerContentCreatorTest.swift +++ b/Tests/Create/ID3FrameWithIntegerContentCreatorTest.swift @@ -45,9 +45,4 @@ struct ID3FrameWithIntegerContentCreatorTest { #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testNoFrameCreationWhenThereIsNoContent", testNoFrameCreationWhenThereIsNoContent), - ("testFrameCreationWhenThereIsContent", testFrameCreationWhenThereIsContent) - ] } diff --git a/Tests/Create/ID3FrameWithStringContentCreatorTest.swift b/Tests/Create/ID3FrameWithStringContentCreatorTest.swift index daeedb50..2b987506 100644 --- a/Tests/Create/ID3FrameWithStringContentCreatorTest.swift +++ b/Tests/Create/ID3FrameWithStringContentCreatorTest.swift @@ -44,9 +44,4 @@ struct ID3FrameWithStringContentCreatorTest { #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testNoFrameCreationWhenThereIsNoFrameData", testNoFrameCreationWhenThereIsNoFrameData), - ("testFrameCreationWhenThereIsFrameData", testFrameCreationWhenThereIsFrameData) - ] } diff --git a/Tests/Create/ID3FramesWithLocalizedContentCreatorTest.swift b/Tests/Create/ID3FramesWithLocalizedContentCreatorTest.swift index ba55c4d8..e43fca5a 100644 --- a/Tests/Create/ID3FramesWithLocalizedContentCreatorTest.swift +++ b/Tests/Create/ID3FramesWithLocalizedContentCreatorTest.swift @@ -41,9 +41,4 @@ struct ID3FramesWithLocalizedContentCreatorTest { )) .build() } - - static let allTests = [ - ("testNothingIsCreatedWheLyricsDataIsNotSet", testNothingIsCreatedWheLyricsDataIsNotSet), - ("testCreateFrameForValidData", testCreateFrameForValidData) - ] } diff --git a/Tests/Create/ID3GenreFrameCreatorTest.swift b/Tests/Create/ID3GenreFrameCreatorTest.swift index c4186e6c..4a629f7e 100644 --- a/Tests/Create/ID3GenreFrameCreatorTest.swift +++ b/Tests/Create/ID3GenreFrameCreatorTest.swift @@ -41,9 +41,4 @@ struct ID3GenreFrameCreatorTest { #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testFrameCreationWhenThereIsAGenre", testFrameCreationWhenThereIsAGenre), - ("testNoFrameCreationWhenThereIsNoGenre", testNoFrameCreationWhenThereIsNoGenre) - ] } diff --git a/Tests/Create/ID3ISO88591StringToByteAdapterTest.swift b/Tests/Create/ID3ISO88591StringToByteAdapterTest.swift index 99706c4c..e71bc477 100644 --- a/Tests/Create/ID3ISO88591StringToByteAdapterTest.swift +++ b/Tests/Create/ID3ISO88591StringToByteAdapterTest.swift @@ -21,8 +21,4 @@ struct ID3ISO88591StringToByteAdapterTest { #expect(bytes == ENCODING + STRING) } - - static let allTests = [ - ("testEncodeStringToISO88591WithEncodingByte", testEncodeStringToISO88591WithEncodingByte) - ] } diff --git a/Tests/Create/ID3LocalizedFrameCreatorTest.swift b/Tests/Create/ID3LocalizedFrameCreatorTest.swift index d9d01dc9..d8990aa7 100644 --- a/Tests/Create/ID3LocalizedFrameCreatorTest.swift +++ b/Tests/Create/ID3LocalizedFrameCreatorTest.swift @@ -75,10 +75,4 @@ struct ID3LocalizedFrameCreatorTest { 0xFE, 0x6C, 0x00, 0x79, 0x00, 0x72, 0x00, 0x69, 0x00, 0x63, 0x00, 0x73, 0x00]) } - - static let allTests = [ - ("testCreatev2", testCreatev2), - ("testCreatev3", testCreatev3), - ("testCreatev4", testCreatev4) - ] } diff --git a/Tests/Create/ID3RecordingDateTimeFrameCreatorTest.swift b/Tests/Create/ID3RecordingDateTimeFrameCreatorTest.swift index 5c0cf246..ebe0be34 100644 --- a/Tests/Create/ID3RecordingDateTimeFrameCreatorTest.swift +++ b/Tests/Create/ID3RecordingDateTimeFrameCreatorTest.swift @@ -32,9 +32,4 @@ struct ID3RecordingDateTimeFrameCreatorTest { #expect(timestampCreator.createFromRecordingDateTimeHasBeenCalled) #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testFrameCreationWhenThereIsACompleteRecordingDateTime", - testFrameCreationWhenThereIsACompleteRecordingDateTime) - ] } diff --git a/Tests/Create/ID3RecordingDayMonthFrameCreatorTest.swift b/Tests/Create/ID3RecordingDayMonthFrameCreatorTest.swift index 04401237..fdd8d58a 100644 --- a/Tests/Create/ID3RecordingDayMonthFrameCreatorTest.swift +++ b/Tests/Create/ID3RecordingDayMonthFrameCreatorTest.swift @@ -60,10 +60,4 @@ struct ID3RecordingDayMonthFrameCreatorTest { #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testFrameCreationWhenThereIsADayAndAMonth", testFrameCreationWhenThereIsADayAndAMonth), - ("testNoFrameCreationWhenThereIsNoDay", testNoFrameCreationWhenThereIsNoDay), - ("testNoFrameCreationWhenThereIsNoMonth", testNoFrameCreationWhenThereIsNoMonth) - ] } diff --git a/Tests/Create/ID3TagCreatorTest.swift b/Tests/Create/ID3TagCreatorTest.swift index 45b6d692..a56c1945 100644 --- a/Tests/Create/ID3TagCreatorTest.swift +++ b/Tests/Create/ID3TagCreatorTest.swift @@ -48,10 +48,4 @@ struct ID3TagCreatorTest { ) ) } - - static let allTests = [ - ("testGenerateValidData", testGenerateValidData), - ("testNoValidFrameData", testNoValidFrameData), - ("testTagTooBig", testTagTooBig) - ] } diff --git a/Tests/Create/ID3TimestampCreatorTest.swift b/Tests/Create/ID3TimestampCreatorTest.swift index 8ec4d529..f5756e85 100644 --- a/Tests/Create/ID3TimestampCreatorTest.swift +++ b/Tests/Create/ID3TimestampCreatorTest.swift @@ -56,13 +56,4 @@ struct ID3TimestampCreatorTest { #expect(timestampCreator.createFrom(recordingDateTime: recordingTime) == nil) } - - static let allTests = [ - ("testCreateTimestampCorrectly", testCreateTimestampCorrectly), - ("testNilDay", testNilDay), - ("testNilMonth", testNilMonth), - ("testNilYear", testNilYear), - ("testNilHour", testNilHour), - ("testNilMinute", testNilMinute) - ] } diff --git a/Tests/Create/ID3TrackPositionFrameCreatorTest.swift b/Tests/Create/ID3TrackPositionFrameCreatorTest.swift index cc9be1d6..339713ee 100644 --- a/Tests/Create/ID3TrackPositionFrameCreatorTest.swift +++ b/Tests/Create/ID3TrackPositionFrameCreatorTest.swift @@ -41,9 +41,4 @@ struct ID3TrackPositionCreatorTest { #expect(newTagBytes == newFrameBytes) } - - static let allTests = [ - ("testFrameCreationWhenThereIsATrackPosition", testFrameCreationWhenThereIsATrackPosition), - ("testNoFrameCreationWhenThereIsNoTrackPosition", testNoFrameCreationWhenThereIsNoTrackPosition) - ] } diff --git a/Tests/Create/ID3UTF16StringToByteAdapterTest.swift b/Tests/Create/ID3UTF16StringToByteAdapterTest.swift index d55223a3..4ff350e1 100644 --- a/Tests/Create/ID3UTF16StringToByteAdapterTest.swift +++ b/Tests/Create/ID3UTF16StringToByteAdapterTest.swift @@ -22,8 +22,4 @@ struct ID3UTF16StringToByteAdapterTest { #expect(bytes == ENCODING + BOM + STRING) } - - static let allTests = [ - ("testEncodeStringToUTF16WithEncodingByte", testEncodeStringToUTF16WithEncodingByte) - ] } diff --git a/Tests/Frame/ID3FrameConfigurationTest.swift b/Tests/Frame/ID3FrameConfigurationTest.swift index 6f4fa005..31a6940d 100644 --- a/Tests/Frame/ID3FrameConfigurationTest.swift +++ b/Tests/Frame/ID3FrameConfigurationTest.swift @@ -12,8 +12,4 @@ struct ID3FrameConfigurationTest { @Test func invalidIdentifierName() { #expect(ID3FrameConfiguration().frameTypeFor(identifier: "::not-valid::", version: .version2) == .invalid) } - - static let allTests = [ - ("testInvalidIdentifierName", invalidIdentifierName) - ] } diff --git a/Tests/Mp3/Mp3FileReaderTest.swift b/Tests/Mp3/Mp3FileReaderTest.swift index 91ff4c10..e6776cad 100644 --- a/Tests/Mp3/Mp3FileReaderTest.swift +++ b/Tests/Mp3/Mp3FileReaderTest.swift @@ -64,14 +64,4 @@ struct Mp3FileReaderTest { // The file has no ID3 tag #expect(id3TagData == nil) } - - static let allTests = [ - ("testNotAnMP3FileWhenReadingEntireFile", testNotAnMP3FileWhenReadingEntireFile), - ("testMP3FileWhenReadingEntireFile", testMP3FileWhenReadingEntireFile), - ("testNotAnMP3fileWhenReadingID3Tag", testNotAnMP3fileWhenReadingID3Tag), - ("testMP3fileWhenReadingID3Tag", testMP3fileWhenReadingID3Tag), - ("testNonExistentMP3fileWhenReadingID3Tag", testNonExistentMP3fileWhenReadingID3Tag), - ("testOnlyReadsID3Tag", testOnlyReadsID3Tag), - ("testIgnoresWhenMissingID3Tag", testIgnoresWhenMissingID3Tag) - ] } diff --git a/Tests/Mp3/Mp3FileWriterTest.swift b/Tests/Mp3/Mp3FileWriterTest.swift index a10f2ac8..8a81e178 100644 --- a/Tests/Mp3/Mp3FileWriterTest.swift +++ b/Tests/Mp3/Mp3FileWriterTest.swift @@ -30,8 +30,4 @@ struct Mp3FileWriterTest { #expect((readTag?.frames[.title] as? ID3FrameWithStringContent)?.content == "Test Title") #expect((readTag?.frames[.album] as? ID3FrameWithStringContent)?.content == "Test Album") } - - static let allTests = [ - ("testWritingWithCurrentTag", testWritingWithCurrentTag) - ] } diff --git a/Tests/Parse/ID3AttachedPictureFrameContentParsingOperationTest.swift b/Tests/Parse/ID3AttachedPictureFrameContentParsingOperationTest.swift index d9461308..fc01c99b 100644 --- a/Tests/Parse/ID3AttachedPictureFrameContentParsingOperationTest.swift +++ b/Tests/Parse/ID3AttachedPictureFrameContentParsingOperationTest.swift @@ -56,9 +56,4 @@ struct ID3AttachedPictureFrameContentParsingOperationTest { }) } } - - static let allTests = [ - ("testSetTagAttachedPictureJpg", testSetTagAttachedPictureJpg), - ("testSetTagAttachedPicturePng", testSetTagAttachedPicturePng) - ] } diff --git a/Tests/Parse/ID3DiscPositionStringAdapterTest.swift b/Tests/Parse/ID3DiscPositionStringAdapterTest.swift index 6381e79a..9807f030 100644 --- a/Tests/Parse/ID3DiscPositionStringAdapterTest.swift +++ b/Tests/Parse/ID3DiscPositionStringAdapterTest.swift @@ -29,10 +29,4 @@ struct ID3DiscPositionStringAdapterTest { #expect(discPosition.part == 0) #expect(discPosition.total == nil) } - - static let allTests = [ - ("testAdaptNotANumberDiscPosition", testAdaptNotANumberDiscPosition), - ("testAdaptDiscPositionWithoutTotalDiscs", testAdaptDiscPositionWithoutTotalDiscs), - ("testAdaptDiscPositionWithTotalDiscs", testAdaptDiscPositionWithTotalDiscs) - ] } diff --git a/Tests/Parse/ID3FrameContentSizeParserTest.swift b/Tests/Parse/ID3FrameContentSizeParserTest.swift index 53c4a0d8..a008da65 100644 --- a/Tests/Parse/ID3FrameContentSizeParserTest.swift +++ b/Tests/Parse/ID3FrameContentSizeParserTest.swift @@ -58,10 +58,4 @@ import Testing 14 ) } - - static let allTests = [ - ("testParseFrameContentSizeV2", testParseFrameContentSizeV2), - ("testParseFrameContentSizeV3", testParseFrameContentSizeV3), - ("testParseFrameContentSizeV4", testParseFrameContentSizeV4) - ] } diff --git a/Tests/Parse/ID3FrameSizeParserTest.swift b/Tests/Parse/ID3FrameSizeParserTest.swift index d48f6f1e..2df5756a 100644 --- a/Tests/Parse/ID3FrameSizeParserTest.swift +++ b/Tests/Parse/ID3FrameSizeParserTest.swift @@ -42,9 +42,4 @@ struct ID3FrameSizeParserTest { mp3.length + ID3FrameConfiguration().headerSizeFor(version: .version3) ) } - - static let allTests = [ - ("testParseFrameContentSizeV2", testParseFrameContentSizeV2), - ("testParseFrameContentSizeV3", testParseFrameContentSizeV3) - ] } diff --git a/Tests/Parse/ID3GenreStringAdapterTest.swift b/Tests/Parse/ID3GenreStringAdapterTest.swift index 438f8993..08d9e93b 100644 --- a/Tests/Parse/ID3GenreStringAdapterTest.swift +++ b/Tests/Parse/ID3GenreStringAdapterTest.swift @@ -36,11 +36,4 @@ import Testing #expect(ID3GenreStringAdapter().adapt(genre: "(XXX)").identifier == nil) #expect(ID3GenreStringAdapter().adapt(genre: "(XXX)").description == "(XXX)") } - - static let allTests = [ - ("testAdaptGenreWithDescription", testAdaptGenreWithDescription), - ("testAdaptGenreWithoutDescription", testAdaptGenreWithoutDescription), - ("testAdaptGenreWithoutGenreIdentifier", testAdaptGenreWithoutGenreIdentifier), - ("testAdaptID3v3NewGenresNotNumeric", testAdaptID3v3NewGenresNotNumeric) - ] } diff --git a/Tests/Parse/ID3LocalizedFrameParsingOperationTest.swift b/Tests/Parse/ID3LocalizedFrameParsingOperationTest.swift index 347b76f9..193d37c1 100644 --- a/Tests/Parse/ID3LocalizedFrameParsingOperationTest.swift +++ b/Tests/Parse/ID3LocalizedFrameParsingOperationTest.swift @@ -69,9 +69,4 @@ struct ID3LocalizedFrameParsingOperationTest { + content ) } - - static let allTests = [ - ("testParsingValidFrame", testParsingValidFrame), - ("testParsingInvalidLanguage", testParsingInvalidLanguage) - ] } diff --git a/Tests/Parse/ID3PictureTypeAdapterTest.swift b/Tests/Parse/ID3PictureTypeAdapterTest.swift index 7ae97145..73a6c790 100644 --- a/Tests/Parse/ID3PictureTypeAdapterTest.swift +++ b/Tests/Parse/ID3PictureTypeAdapterTest.swift @@ -54,11 +54,4 @@ struct ID3PictureTypeAdapterTest { #expect(id3PictureTypeAdapter.adapt(frame: frame, format: .png, version: .version3) == .frontCover) } - - static let allTests = [ - ("testExtractTypeFromV2TagJpg", testExtractTypeFromV2TagJpg), - ("testExtractTypeFromV2TagPng", testExtractTypeFromV2TagPng), - ("testExtractTypeFromV3TagJpg", testExtractTypeFromV3TagJpg), - ("testExtractTypeFromV3TagPng", testExtractTypeFromV3TagPng) - ] } diff --git a/Tests/Parse/ID3RecordingTimestampOperationTest.swift b/Tests/Parse/ID3RecordingTimestampOperationTest.swift index e45dc990..ac1cf38d 100644 --- a/Tests/Parse/ID3RecordingTimestampOperationTest.swift +++ b/Tests/Parse/ID3RecordingTimestampOperationTest.swift @@ -64,9 +64,4 @@ struct ID3RecordingTimeFrameContentParsingOperationTest { [0x03] + [UInt8]("2016".utf8) ) } - - static let allTests = [ - ("testframeContentValidTimestamp", testframeContentValidTimestamp), - ("testframeContentWithYearInsteadOfTimestamp", testframeContentWithYearInsteadOfTimestamp) - ] } diff --git a/Tests/Parse/ID3StringContentParsingOperationTest.swift b/Tests/Parse/ID3StringContentParsingOperationTest.swift index 94b343df..967bfe06 100644 --- a/Tests/Parse/ID3StringContentParsingOperationTest.swift +++ b/Tests/Parse/ID3StringContentParsingOperationTest.swift @@ -190,12 +190,4 @@ struct ID3StringContentParsingOperationTest { [0x03] + [UInt8](":: π value ::".utf8) ) } - - static let allTests = [ - ("testFrameContentParsedV2", testFrameContentParsedV2), - ("testFrameContentParsedV3", testFrameContentParsedV3), - ("testFrameContentParsedV2utf16", testFrameContentParsedV2utf16), - ("testFrameContentParsedV3utf16", testFrameContentParsedV3utf16), - ("testFrameContentParsedV4utf8", testFrameContentParsedV4utf8) - ] } diff --git a/Tests/Parse/ID3TagSizeParserTest.swift b/Tests/Parse/ID3TagSizeParserTest.swift index b19d0b40..50204dd4 100644 --- a/Tests/Parse/ID3TagSizeParserTest.swift +++ b/Tests/Parse/ID3TagSizeParserTest.swift @@ -20,9 +20,4 @@ struct ID3TagSizeParserTest { let mp3V23 = NSData(contentsOfFile: PathLoader().pathFor(name: "example-v23", fileType: "mp3"))! #expect(ID3TagSizeParser().parse(data: mp3V23) == 245864) } - - static let allTests = [ - ("parseTagSizeV2", parseTagSizeV2), - ("parseFrameContentSizeV3", parseTagSizeV3) - ] } diff --git a/Tests/Parse/ID3TagVersionParserTest.swift b/Tests/Parse/ID3TagVersionParserTest.swift index bbe216c6..852dabea 100644 --- a/Tests/Parse/ID3TagVersionParserTest.swift +++ b/Tests/Parse/ID3TagVersionParserTest.swift @@ -36,10 +36,4 @@ struct ID3TagVersionParserTest { ) #expect(.version3 == ID3TagVersionParser().parse(mp3: mp3WithV2Tag)) } - - static let allTests = [ - ("testExtractVersion2", testExtractVersion2), - ("testExtractVersion3", testExtractVersion3), - ("testDefaultVersion", testDefaultVersion) - ] } diff --git a/Tests/Parse/ID3TrackPositionStringAdapterTest.swift b/Tests/Parse/ID3TrackPositionStringAdapterTest.swift index 878b4798..5eaaad99 100644 --- a/Tests/Parse/ID3TrackPositionStringAdapterTest.swift +++ b/Tests/Parse/ID3TrackPositionStringAdapterTest.swift @@ -29,10 +29,4 @@ struct ID3TrackPositionStringAdapterTest { #expect(trackPosition.part == 0) #expect(trackPosition.total == nil) } - - static let allTests = [ - ("testAdaptNotANumberTrackPosition", testAdaptNotANumberTrackPosition), - ("testAdaptTrackPositionWithoutTotalTracks", testAdaptTrackPositionWithoutTotalTracks), - ("testAdaptTrackPositionWithTotalTrack", testAdaptTrackPositionWithTotalTrack) - ] } diff --git a/Tests/Tag/ID3TagPresenceTest.swift b/Tests/Tag/ID3TagPresenceTest.swift index 2c134283..35fb4634 100644 --- a/Tests/Tag/ID3TagPresenceTest.swift +++ b/Tests/Tag/ID3TagPresenceTest.swift @@ -43,11 +43,4 @@ struct ID3TagPresenceTest { #expect(!presence.isTagPresentIn(mp3: mp3Sample, version: .version2)) #expect(!presence.isTagPresentIn(mp3: mp3Sample, version: .version3)) } - - static let allTests = [ - ("testHeaderVersion2IsPresent", testHeaderVersion2IsPresent), - ("testHeaderVersion3IsPresent", testHeaderVersion3IsPresent), - ("testTagNotPresent", testTagNotPresent), - ("testTagNotPresentSizeTooSmall", testTagNotPresentSizeTooSmall) - ] } diff --git a/Tests/Tag/ID3TagTest.swift b/Tests/Tag/ID3TagTest.swift index a3705824..5bbe4608 100644 --- a/Tests/Tag/ID3TagTest.swift +++ b/Tests/Tag/ID3TagTest.swift @@ -232,11 +232,6 @@ struct ID3TagTest { """ ) } - - static let allTests = [ - ("testDebugDescriptionv3", testDebugDescriptionv3), - ("testDebugDescriptionv4", testDebugDescriptionv4) - ] } // swiftlint:enable line_length