Skip to content

Commit

Permalink
:octocat: remove QROptionsTrait::$svgViewBoxSize (#222)
Browse files Browse the repository at this point in the history
  • Loading branch information
codemasher committed Oct 24, 2023
1 parent 8c0da25 commit 57448af
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
2 changes: 1 addition & 1 deletion src/Output/QRMarkupSVG.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ protected function createMarkup(bool $saveToFile):string{
protected function getViewBox():string{
[$width, $height] = $this->getOutputDimensions();

return sprintf('0 0 %s %s', ($this->options->svgViewBoxSize ?? $width), ($this->options->svgViewBoxSize ?? $height));
return sprintf('0 0 %s %s', $width, $height);
}

/**
Expand Down
13 changes: 0 additions & 13 deletions src/QROptionsTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -380,19 +380,6 @@ trait QROptionsTrait{
*/
protected string $svgDefs = '';

/**
* SVG viewBox size. A single integer number which defines width/height of the viewBox attribute.
*
* viewBox="0 0 x x"
*
* @deprecated 5.0.0 use QRMarkupSVG::getViewBox() instead
* @see \chillerlan\QRCode\Output\QRMarkupSVG::getViewBox()
*
* @see https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBox
* @see https://css-tricks.com/scale-svg/#article-header-id-3
*/
protected ?int $svgViewBoxSize = null;

/**
* Sets the value for the "preserveAspectRatio" on the `<svg>` element
*
Expand Down

0 comments on commit 57448af

Please sign in to comment.