generated from chingu-voyages/voyage-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question Component Page updated #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aasmal97
commented
Nov 10, 2023
•
edited
Loading
edited
- Added share btn logic and necessary metadata
- Added fullscreen btn logic
- Added descriptive dropdown on icon buttons for accessibility and improved ux on question view and answer view. This includes a reusable component
- Refactored and Finalized timer/stopwatch logic. In addition, added timer feature where current time is saved to local storage when an id of question is provided. Upon re-load, you can grab the old value and continue the timer.
- Updated prisma schema for answer options/correct answer, for easier autograding and rendering (attaching ids to every element in the array). This prevents duplicate key bugs.
- Updated seed file to account for above change in prisma schema
… timer modal pop up
…e an event occurred
…timer based off id
…state to components
…function body of a different component, due to embedded setState functions
…xtra dropdown that appears when a link is copied
…touch or mouse handlers
…ccommodate for this
Co-authored-by: ccrump1280 <connor.crump128@gmail.com>
IrhaAli
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.