generated from chingu-voyages/voyage-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ch 108 fix and style recipe tag filtering on the search page #102
Merged
timDeHof
merged 7 commits into
development
from
CH-108-fix-and-style-recipe-tag-filtering-on-the-search-page
Nov 12, 2023
Merged
Ch 108 fix and style recipe tag filtering on the search page #102
timDeHof
merged 7 commits into
development
from
CH-108-fix-and-style-recipe-tag-filtering-on-the-search-page
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button styles in Filters.jsx have been updated to provide a smoother transition effect and a more consistent look and feel. The changes include adding a transition effect, changing the background color to a lighter shade of tangerine, and adding a hover effect that includes a shadow and a slight scale up. The border color now changes based on whether the tag is selected or not, providing a clearer visual cue to the user.
… color scheme The tag filtering logic has been optimized to improve performance. Instead of using nested array methods, a Set is now used to store the IDs of tags present in the filtered recipes. This change reduces the time complexity of the filtering operation. The UI color scheme has been updated from 'tangerine' to 'watermelon' to improve visibility and user experience. The 'flex-wrap' property has been added to the container div to ensure proper wrapping of items on smaller screens
…ser experience The page heading has been upgraded from h2 to h1 for better SEO and accessibility. The heading is now placed above the SvgComponent for a more logical flow of information. The "Orange Ball" div's top position in medium devices has been adjusted to improve the overall layout and visual appeal.
✅ Deploy Preview for yumyumyesdev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…t styles for better readability The Heading component was replaced with a native h5 tag to reduce the number of dependencies and improve performance. The styles of the filter buttons were adjusted to improve readability and user interaction. The border color and background color were changed to provide better contrast and the space between list items was increased for better visual separation.
…ments The tag filtering logic has been improved to prevent duplicate tags from appearing in the list. The UI has also been enhanced with changes to the color scheme and button styles to improve readability and user experience. The changes were made to provide a more intuitive and visually appealing interface for the users.
…ring-on-the-search-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed some bugs in the filtering and add better styling.