Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch 108 fix and style recipe tag filtering on the search page #102

Conversation

timDeHof
Copy link
Contributor

fixed some bugs in the filtering and add better styling.

The button styles in Filters.jsx have been updated to provide a smoother transition effect and a
more consistent look and feel. The changes include adding a transition effect, changing the
background color to a lighter shade of tangerine, and adding a hover effect that includes a shadow
and a slight scale up. The border color now changes based on whether the tag is selected or not,
providing a clearer visual cue to the user.
… color scheme

The tag filtering logic has been optimized to improve performance. Instead of using nested array
methods, a Set is now used to store the IDs of tags present in the filtered recipes. This change
reduces the time complexity of the filtering operation. The UI color scheme has been updated from
'tangerine' to 'watermelon' to improve visibility and user experience. The 'flex-wrap' property has
been added to the container div to ensure proper wrapping of items on smaller screens
…ser experience

The page heading has been upgraded from h2 to h1 for better SEO and accessibility. The heading is
now placed above the SvgComponent for a more logical flow of information. The "Orange Ball" div's
top position in medium devices has been adjusted to improve the overall layout and visual appeal.
Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for yumyumyesdev ready!

Name Link
🔨 Latest commit a550e6c
🔍 Latest deploy log https://app.netlify.com/sites/yumyumyesdev/deploys/65501bda4402720008c8004c
😎 Deploy Preview https://deploy-preview-102--yumyumyesdev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 10, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

timDeHof and others added 3 commits November 10, 2023 18:30
…t styles for better readability

The Heading component was replaced with a native h5 tag to reduce the number of dependencies and
improve performance. The styles of the filter buttons were adjusted to improve readability and user
interaction. The border color and background color were changed to provide better contrast and the
space between list items was increased for better visual separation.
…ments

The tag filtering logic has been improved to prevent duplicate tags from appearing in the list. The
UI has also been enhanced with changes to the color scheme and button styles to improve readability
and user experience. The changes were made to provide a more intuitive and visually appealing
interface for the users.
@timDeHof timDeHof merged commit f4182af into development Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant