Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch 99 fix plastic balls placement on search page #90

Merged

Conversation

timDeHof
Copy link
Contributor

@timDeHof timDeHof commented Nov 7, 2023

refactored Search.jsx and removed redundant plastic balls. styled grid and its component to respond to different view sizes.

…bile responsiveness

The padding and width of the 'FeatureOfTheDay' component have been adjusted to improve the mobile
responsiveness of the application. The button width is now full on mobile and half on larger
screens. The padding-top on the main div has been removed to better utilize the screen space on
smaller devices. The flex properties have been adjusted to apply only on larger screens, ensuring a
more compact and user-friendly layout on mobile devices.
…and readability

The CSS classes in recipe-card.jsx have been adjusted to improve the responsiveness of the
RecipeCard component. The width of the card and image now take up the full width of their parent
container, and the text within the card will break into new lines if it's too long, improving
readability. The flex container within the card now wraps its children, allowing for better layout
on smaller screens. In global.css, unnecessary whitespace in the .text-no-stroke class has been
removed for cleaner code.
… and layout consistency

The grid styling in the recipe list component was adjusted to improve the responsiveness of the
layout across different screen sizes. The 'w-full' class was added to ensure the grid takes up the
full width of its container, and the 'gap-12' class was replaced with 'md:gap-10' to reduce the gap
between grid items on medium-sized screens for a more consistent layout.
… better UI/UX

The layout of the Search page has been adjusted to improve the user experience. The flex container
and its child elements have been modified to better fit the content and improve the overall layout.
The width of some elements has been adjusted to prevent overflow and maintain consistency across
different screen sizes. The positioning of the colored balls has been adjusted for better visual
appeal. Redundant colored balls have been removed to declutter the UI and make it more
user-friendly.
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for yumyumyesdev ready!

Name Link
🔨 Latest commit 4d089db
🔍 Latest deploy log https://app.netlify.com/sites/yumyumyesdev/deploys/654b8743ee20c80008cf2cf9
😎 Deploy Preview https://deploy-preview-90--yumyumyesdev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Contributor

@joekotvas joekotvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some weird positioning at 1028 px, and below that it is not centered. The cards look a lot better, though.

@joekotvas joekotvas merged commit 0fce953 into development Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants