Hw model cold reset support #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquarton
commented
Apr 8, 2024
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
3 times, most recently
from
bfeaf18 to
b4d89ce
Compare
nquarton
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
rusty1968,
bluegate010,
FerralCoder,
ajisaxena,
vsonims and
JohnTraverAmd
as code owners
jlmahowa-amd
previously approved these changes
Apr 15, 2024
rusty1968
reviewed
Apr 22, 2024
rusty1968
previously approved these changes
Apr 22, 2024
korran
reviewed
Apr 22, 2024
korran
reviewed
Apr 22, 2024
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
from
b4d89ce to
77663af
Compare
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
from
77663af to
af33d6d
Compare
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
from
af33d6d to
756b1bc
Compare
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
from
756b1bc to
c4f4f72
Compare
ArthurHeymans
approved these changes
Jul 10, 2024
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
from
c4f4f72 to
b5e4165
Compare
jhand2
previously approved these changes
Jul 10, 2024
JohnTraverAmd
previously approved these changes
Jul 10, 2024
- separating InitParams from BootParams - boot() can be used after a reset to boot without re-initializing the model
nquarton
force-pushed
the
hw_model_cold_reset_support
branch
from
b5e4165 to
38ed754
Compare
jhand2
approved these changes
Jul 10, 2024
JohnTraverAmd
approved these changes
Jul 10, 2024
FerralCoder
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.