Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zerocopy from 0.6.6 to 0.8.8. #1765

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

clundin25
Copy link
Contributor

@clundin25 clundin25 commented Nov 1, 2024

This PR does not optimize out a large portion of copies. Ideally it will be done in follow up PRs.

There are slight changes made to optimize panics out of the final binary.

This resolves #1721

@clundin25 clundin25 force-pushed the zero-copy-update branch 5 times, most recently from bd29883 to cef6529 Compare November 15, 2024 16:30
zhalvorsen
zhalvorsen previously approved these changes Dec 3, 2024
Copy link
Contributor

@zhalvorsen zhalvorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cherry pick this onto the 2.x branch as soon as we can because it touches so many files and tests.

jhand2
jhand2 previously approved these changes Dec 4, 2024
@jhand2 jhand2 mentioned this pull request Dec 5, 2024
12 tasks
@clundin25 clundin25 dismissed stale reviews from jhand2 and zhalvorsen via 4060762 December 18, 2024 20:36
@clundin25 clundin25 force-pushed the zero-copy-update branch 3 times, most recently from 2fe267d to a3f8a6f Compare December 18, 2024 20:53
This PR does not optimize out a large portion of copies. Ideally it will
be done in follow up PRs.

There are portions of code that are slightly modified to keep panics out
of the final binary.
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew! This looked like it was a big pain to write.

Looks good; just a couple of questions

Cargo.toml Show resolved Hide resolved
drivers/src/bounded_address.rs Show resolved Hide resolved
runtime/src/get_idev_csr.rs Show resolved Hide resolved
@jhand2 jhand2 merged commit c7f7794 into chipsalliance:main Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update zerocopy to 0.8.6
5 participants