-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zerocopy from 0.6.6 to 0.8.8. #1765
Conversation
78a5027
to
718296c
Compare
bd29883
to
cef6529
Compare
cef6529
to
ef2df78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should cherry pick this onto the 2.x branch as soon as we can because it touches so many files and tests.
ef2df78
to
4060762
Compare
2fe267d
to
a3f8a6f
Compare
This PR does not optimize out a large portion of copies. Ideally it will be done in follow up PRs. There are portions of code that are slightly modified to keep panics out of the final binary.
a3f8a6f
to
ec111ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew! This looked like it was a big pain to write.
Looks good; just a couple of questions
This PR does not optimize out a large portion of copies. Ideally it will be done in follow up PRs.
There are slight changes made to optimize panics out of the final binary.
This resolves #1721