Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 'authorize_and_stash' more extensively #1772

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

ArthurHeymans
Copy link
Contributor

This adds:

  • A check on stash on both failing and succeeding paths
  • A succeeding path test

This adds:
- A check on stash on both failing and succeeding paths
- A succeeding path test

Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
@ArthurHeymans ArthurHeymans force-pushed the ArthurHeymans/Authorize_Stash_test branch from cfee63f to 932d842 Compare November 5, 2024 18:46
@jhand2 jhand2 requested a review from zhalvorsen November 13, 2024 18:11
mhatrevi
mhatrevi previously approved these changes Nov 13, 2024
@mhatrevi mhatrevi force-pushed the ArthurHeymans/Authorize_Stash_test branch from e56b07f to 167af42 Compare November 13, 2024 22:08
zhalvorsen
zhalvorsen previously approved these changes Nov 13, 2024
@jhand2 jhand2 enabled auto-merge (rebase) November 13, 2024 22:23
@jhand2 jhand2 disabled auto-merge November 13, 2024 22:23
@jhand2 jhand2 enabled auto-merge (squash) November 13, 2024 22:24
@jhand2 jhand2 merged commit b551421 into main Nov 13, 2024
11 checks passed
mhatrevi pushed a commit that referenced this pull request Nov 18, 2024
This adds:
- A check on stash on both failing and succeeding paths
- A succeeding path test

Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
(cherry picked from commit b551421)
mhatrevi pushed a commit that referenced this pull request Nov 19, 2024
This adds:
- A check on stash on both failing and succeeding paths
- A succeeding path test

Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
(cherry picked from commit b551421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants