-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 'authorize_and_stash' more extensively #1772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
swenson and
vsonims
as code owners
November 5, 2024 17:12
This adds: - A check on stash on both failing and succeeding paths - A succeeding path test Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com>
ArthurHeymans
force-pushed
the
ArthurHeymans/Authorize_Stash_test
branch
from
November 5, 2024 18:46
cfee63f
to
932d842
Compare
zhalvorsen
previously approved these changes
Nov 13, 2024
runtime/tests/runtime_integration_tests/test_authorize_and_stash.rs
Outdated
Show resolved
Hide resolved
mhatrevi
previously approved these changes
Nov 13, 2024
mhatrevi
force-pushed
the
ArthurHeymans/Authorize_Stash_test
branch
from
November 13, 2024 22:08
e56b07f
to
167af42
Compare
zhalvorsen
previously approved these changes
Nov 13, 2024
mhatrevi
force-pushed
the
ArthurHeymans/Authorize_Stash_test
branch
from
November 13, 2024 22:21
167af42
to
5ecfafc
Compare
jhand2
approved these changes
Nov 13, 2024
mhatrevi
pushed a commit
that referenced
this pull request
Nov 18, 2024
This adds: - A check on stash on both failing and succeeding paths - A succeeding path test Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com> (cherry picked from commit b551421)
mhatrevi
pushed a commit
that referenced
this pull request
Nov 19, 2024
This adds: - A check on stash on both failing and succeeding paths - A succeeding path test Signed-off-by: Arthur Heymans <arthur.heymans@9elements.com> (cherry picked from commit b551421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds: