Fixing release CI failures and adding frozen 1.1 ROM #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquarton
commented
Nov 21, 2024
nquarton
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
swenson,
vsonims and
FerralCoder
as code owners
korran
reviewed
Nov 21, 2024
nquarton
force-pushed
the
nquarton/fix_nightly_add_1_1_ci_rom
branch
4 times, most recently
from
2727939 to
b278314
Compare
nquarton
had a problem deploying
to
github-pages
GitHub Actions
Failure
nquarton
force-pushed
the
nquarton/fix_nightly_add_1_1_ci_rom
branch
from
b278314 to
5f87e7f
Compare
nquarton
had a problem deploying
to
github-pages
GitHub Actions
Failure
Prevents a release being made from main when tests were actuall run on a different branch/commit
|
This run shows it solving all the test failures in the nightly. (The final publish step fails as expected since this is not the main branch). |
jlmahowa-amd
approved these changes
Nov 23, 2024
jhand2
approved these changes
Nov 23, 2024
mhatrevi
approved these changes
Nov 25, 2024
mhatrevi
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Fixing release CI failures and adding frozen 1.1 ROM * Changing CI ROM version from rust feature to environment variable * Removing reference to main branch in release flow Prevents a release being made from main when tests were actuall run on a different branch/commit (cherry picked from commit 5daf1b4)
jhand2
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Fixing release CI failures and adding frozen 1.1 ROM * Changing CI ROM version from rust feature to environment variable * Removing reference to main branch in release flow Prevents a release being made from main when tests were actuall run on a different branch/commit (cherry picked from commit 5daf1b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.