Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#32) Update Help URLs to short links #40

Merged
merged 1 commit into from
Feb 1, 2024
Merged

(#32) Update Help URLs to short links #40

merged 1 commit into from
Feb 1, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates all the URLs shown when a rule fais the validation to use
ch0.co shortlink instead of the full URL to the documentation site.

Motivation and Context

Using a full URL when outputting in the console uses unnecessary screenspace, and using a short link allows us more customizability if there is a need for it in the future.

Testing

  1. Run choco new default.
  2. With the extension installed, run choco pack <PATH_TO_NUSPEC> with the path to the created package.
  3. Verify all URLs outputted in the console uses the ch0.co shortlink.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #32

@AdmiringWorm AdmiringWorm requested review from corbob and gep13 January 28, 2024 12:09
@AdmiringWorm AdmiringWorm self-assigned this Jan 28, 2024
@AdmiringWorm AdmiringWorm changed the title (#32) Update Help URLs to short link (#32) Update Help URLs to short links Jan 28, 2024
@AdmiringWorm @corbob
(chocolatey-community#32) Update Help URLs to short link
034cca1 
This updates all the URLs shown when a rule fais the validation to use
ch0.co shortlink instead of the full URL to the documentation site.
@corbob corbob force-pushed the AdmiringWorm/32-Replace-Help-URLs-with-a-short-link-version-of-the-URLs branch from 8f3811b to 034cca1 Compare February 1, 2024 18:41
corbob
corbob approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corbob corbob enabled auto-merge February 1, 2024 18:42
@corbob
Copy link
Contributor

corbob commented Feb 1, 2024

Thanks for getting these fixed up @AdmiringWorm 👍

@corbob corbob merged commit 58e095f into chocolatey-community:develop Feb 1, 2024
1 check passed
@AdmiringWorm AdmiringWorm deleted the AdmiringWorm/32-Replace-Help-URLs-with-a-short-link-version-of-the-URLs branch February 1, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbob corbob corbob approved these changes

@gep13 gep13 Awaiting requested review from gep13

Assignees

@AdmiringWorm AdmiringWorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Help URLs with a short link version of the URLs
2 participants
@AdmiringWorm @corbob