Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for future OpenFF virtual site releases in AbsoluteAlchemicalFactory #745

Open
IAlibay opened this issue Sep 2, 2024 · 1 comment

Comments

@IAlibay
Copy link
Contributor

IAlibay commented Sep 2, 2024

Follow-up from #509 and #508

We would like to add support for doing AFE calculations using future releases of OpenFF force fields that will contain virtual sites.

This is a partial roadmap item for OpenFE this year, so we would like to help out with this process as much as possible.

To our knowlege, the following actions would be necessary:

  1. Get a technically complete (i.e. no expected changes in vsite types or functional forms) snapshot version of the OpenFF virtual sites FF which we can test against.
  2. Alter AbsoluteAlchemicalFactory to allow for virtual sites, but only when the alchemical region is not directly bonded to any atoms outside the alchemical region.
  3. Add a variety of tests to ensure we retain expected energies, and possibly back to back hydration free energy checks against known results.
@IAlibay
Copy link
Contributor Author

IAlibay commented Sep 2, 2024

@ijpulidos this would be a good one to briefly discuss next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant