-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release notes for 0.10.2 #1208
release notes for 0.10.2 #1208
Conversation
@jchodera can you take a look at this when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good after the comments are addressed!
docs/changelog.rst
Outdated
Enhancements | ||
^^^^^^^^^^^^ | ||
|
||
* Added upport for reading input files (ex yaml, sdf, pdbs) from AWS, GCP, and Azure. See the documentation for [cloudpathlib](https://cloudpathlib.drivendata.org/stable/authentication/) for how to setup authentication. Currently only reading the yaml from S3 is unit tested (ie `perses-cli --yaml s3://perses-testing/template_s3.yaml`), but other cloud providers and input files should work. Please report any issues on our issue tracker! by @mikemhenry in https://github.com/choderalab/perses/pull/1073 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"upport" -> "support"
Do we document how you specify AWS, GCP, and Azure files in the CLI or docs or somewhere?
Also, do all input files work this way, including those paths specified in the YAML? Or just --yaml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All input files, I mention --yaml
since that is the only one we test. I will add a note to see cloud documentation on the format of the URI.
ooof, forgot to run this through my spellcheck! 🙈 Will address everything else 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Release PR for 0.10.2